-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved Overlapping of Chatbot and Scroll to Top Button #400
base: main
Are you sure you want to change the base?
Conversation
@Tejashri-Taral is attempting to deploy a commit to the pranavbarthwal's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, you can contact the mentors for this project. |
@PranavBarthwal LGTM |
@PranavBarthwal , @surajvast1 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PranavBarthwal , Is it okay if I shift the bot on the top of the webpage? |
@Tejashri-Taral No dont move it on the top slide the chatbot a litlte above the chatbot icon |
Hey @surajvast1 , Screenshot Please take a look and review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The position of the chatbot button was fine, I was saying if chatbaot window is open then the chatbot button should not be visible
@PranavBarthwal assign this issue to me, i can fix that the overlapping problem + when the chatbot is opened then the chatbot icon won't be visible and when user clicked outside the chatbot the chatbot become close and again the chatbot icon will be visible and assign this issue under the gssoc24 , excited to contribute in this awesome project. |
here you go @AnkitLuhar |
hey @surajvast1 , @PranavBarthwal look at this if it seems good then, I will commit the changes soon. There is a problem with your scroll-to-top button: when it's clicked, it works, but when I scroll the webpage again, the button becomes entirely white, making the icon invisible in the container. To solve this problem, I made some CSS styling changes to the button. You can look at the attached video to see all the functionalities which i added , here is the list all-the functionalites i added : 1.scroll-to-top button only visible when the user scroll some amount(pixelscroll>350) of the webpage,its enhance the user-experience, here is the screenRecording: screen-capture.7.webmhere is the ScreenShots: |
@surajvast1 , @PranavBarthwal kindly please review my work. |
Apologies for reviewing it late |
@surajvast1, thank you for the appreciation. Today is the last day for merging PRs, and any points from the PR will not be counted afterward. Could you please merge the PR as soon as possible! |
@PranavBarthwal , @surajvast1 kindly please merge the PR, time is running out ! |
@PranavBarthwal, @surajvast1, kindly merge the PR. I have made all the changes as committed. If any further changes are required, please let me know and here is my PR: #460 |
Hi @surajvast1 ,
closes #397
considering the current positioning where the chatbot is in the rightmost bottom of the page and the scroll-to-top button is just above it, I adjusted the scroll-to-top button and chatbot by interchanging their position to avoid overlap.
Video/Screenshots (mandatory)
Here as you can see :