Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] experiment: Adds dark mode decorator for all stories #16670

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 9, 2025

Adds a dark mode storybook decorator, and applies it to all stories.
Although dark mode does not seem to be a priority, it will help developers be more conscious about it when developing components

Screen.Recording.2025-01-09.at.12.42.48.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 9, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review January 9, 2025 20:20
@devinvillarosa devinvillarosa force-pushed the storybook-dark-mode branch 4 times, most recently from ce4a693 to a10e3d9 Compare January 10, 2025 16:49
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

ui-v2/src/storybook/utils/mode-decorator.tsx Outdated Show resolved Hide resolved
@devinvillarosa devinvillarosa merged commit aef571f into main Jan 10, 2025
8 checks passed
@devinvillarosa devinvillarosa deleted the storybook-dark-mode branch January 10, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants