Skip to content

Index all supported properties automatically #271

Description

@malberts

From #257 (comment)

Don't filter on configured properties here:

private function getPropertiesToIndex( ItemId $itemType ): array {
$properties = array_values(
array_map(
fn( FacetConfig $config ) => $config->propertyId,
$this->config->getFacetConfigForItemType( $itemType )
)
);
$properties[] = $this->config->getItemTypeProperty();
return $properties;
}

Instead, allow all properties to be indexed, but use the null return value in https://github.com/ProfessionalWiki/WikibaseFacetedSearch/blob/master/src/Application/DataValueTranslator.php to skip unsupported properties.

Optionally, add config to enable/disable automatic indexing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions