Treat piped item types as alternatives instead of one invalid id - #289
Draft
JeroenDeDauw wants to merge 1 commit into
Draft
JeroenDeDauw wants to merge 1 commit into
JeroenDeDauw wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
============================================
+ Coverage 75.51% 76.44% +0.92%
- Complexity 429 431 +2
============================================
Files 50 50
Lines 1401 1405 +4
============================================
+ Hits 1058 1074 +16
+ Misses 343 331 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
`haswbfacet:P1=Q1|Q2` on the item type property was handed to `ItemId` whole, which rejected it, leaving the query with no item type: the search applied no type filter, the sidebar showed no facets, and `action=wbfacetsearch` failed with `wbfs-item-type-required`. `|` already means OR in a facet value filter, and repeated item type tokens already union, so the value is now split on `|`, valid ids added and invalid segments skipped as a single invalid id already was. Piped and repeated forms now select the same items and the same facets, which remain those of the first item type in the expression. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JeroenDeDauw
force-pushed
the
fix/piped-item-types
branch
from
September 8, 2026 23:30
3124e0f to
6dbdcff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
haswbfacet:P1=Q1|Q2on the item type property was handed toItemIdwhole, which rejected it, leaving thequery with no item type: the search applied no type filter, the sidebar showed no facets, and
action=wbfacetsearchfailed withwbfs-item-type-required.|already means OR in a facet value filter, andrepeated item type tokens already union, so the value is now split on
|, valid ids added and invalid segmentsskipped as a single invalid id already was. Piped and repeated forms now select the same items and the same
facets, which remain those of the first item type in the expression.