#11 Feature/places #15
Conversation
There was a problem hiding this comment.
I love this! I look forward to adding it. I want to go over the changes with @pjlangsam so I can familiarize him with the PR process on github. I will likely have a few things to change including requesting the addition of a test or two before merging. Thank you for whipping this up so quickly!
src/lib/places/location.json
Outdated
| @@ -0,0 +1,31 @@ | |||
| { | |||
There was a problem hiding this comment.
Please move this file to the config directory. My goal is to have all user configurable content in config. It should be easy for other users to set up for other discords (not bay area)
There was a problem hiding this comment.
@stefangimmillaro Moved 👍
|
i forgot to ask - does this PR break the bot if mongo isn't installed on the host? If not, I'm happy to merge it in now. |
|
also would you please update the config/readme.txt to mock some data for the additional secrets.json fields? thank you |
|
@stefangimmillaro - It will break without MongoDB. The reason is because the Google Places API free tier allows up to 1,000 queries within 24 hours. Since raids end at roughly around 8pm, and start up at 7am, I added the Mongo so that it will query the database for similar or like queries first before hitting places API. Over time, I will probably improve this process as it currently searches exact term. Working with mongoose queries is not as easy as SQL queries (to use something along the lines of.... Also, the readme.txt is updated 👍 |
… location was entered
stefangimmillaro
requested review from
pjlangsam
and removed request for
pjlangsam
…ood into feature/places
Please add DATABASE_URL(mongodb, either local or mlab) and GOOGLE_API_KEY (Google Places API key) to secrets.json in order to get this to work properly