Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convolve1Dreverses the filter for its adjoint but does not conjugate it. With complex filters, the forward result is correct while the adjoint and iterative inverse are wrong. Both short and long filters are affected.Conjugate the reversed filter before the existing contiguous copy, preserving the CuPy stride handling from #797. Add regressions against explicitly constructed convolution matrices, correct the adjoint equations, and extend the example with a complex channel inverse.
For example, this adjoint error is about 42.85 on
devand near machine precision with the fix:Validation:
dev. A broader integration run encountered a randomized float32 ChirpRadon dot-test tolerance failure; a 500-seed comparison gives identical results on unmodifieddevand the patched tree, including two failing seeds.AI disclosure: Codex was used to investigate the failure, implement the change, write and run the independent checks, and prepare the documentation and PR text.