[Swaps] Updates to the Asset Swaps fees rationale and specification #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Sep 8, 2024
PaulLaux
reviewed
Sep 17, 2024
This makes updates based on the comments made on #50.
vivek-arte
force-pushed
the
swaps_fees_reword
branch
from
2e6ad47 to
3977a28
Compare
vivek-arte
force-pushed
the
asset_swaps
branch
from
2786578 to
41b606a
Compare
vivek-arte
changed the title
PaulLaux
reviewed
Oct 7, 2024
zips/zip-0228.rst
Outdated
| +-----------------------------+--------------------------+--------------------------------------------------+---------------------------------------------------------------------+ | ||
| |``sizeProofsOrchard`` |``proofsOrchard`` |``byte[sizeProofsOrchard]`` |The aggregated zk-SNARK proof for all Actions in the Action Group. | | ||
| +-----------------------------+--------------------------+--------------------------------------------------+---------------------------------------------------------------------+ | ||
| |``4`` |``timeLimit`` |``uint32`` |The block number (in the future) after which the Actions of the | |
There was a problem hiding this comment.
Please consult @ConstanceBeguier on whether timeLimit should be here or at the actionGroup level.
There was a problem hiding this comment.
moving it to actionGroup we require less changes and I don't see a case where we might need different limit for each action.
There was a problem hiding this comment.
This already is at the Action Group level. The Actions are inside the vActionsOrchard field in this table, so all the Actions in this Action Group have the same timeLimit value.
There was a problem hiding this comment.
Simplified the table format, it should now be clearer.
vivek-arte
force-pushed
the
swaps_fees_reword
branch
4 times, most recently
from
927ae9d to
7d2576a
Compare
vivek-arte
force-pushed
the
swaps_fees_reword
branch
from
d68094e to
55807eb
Compare
…ated. (#73) This changes the Spend Authorization Signature to use the `orchard_action_groups_digest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes clearer the Fees section of ZIP 228, and also adds a rationale section for the fees.
It also changes the specification of the computation of the spend authorization signature