Skip to content

chore(storage): Allow storage to be added after deployment - #3059

Merged
erebe merged 1 commit into
stagingfrom
erebe/storage
Oct 2, 2026
Merged

erebe merged 1 commit into
stagingfrom
erebe/storage

Conversation

@erebe

@erebe erebe commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Backend removed the restriction, so lift it also on the frontend


Summary by cubic

Allows storage to be added to applications and containers after they have been deployed.

  • Removes the disable logic that blocked the "Add Storage" button when the service deployment status was not ready.
  • Removes the tooltip explaining that storage could only be added to never-deployed services.
  • Backend has already lifted the restriction, this aligns the frontend.

Written for commit 05ef461. Summary will update on new commits.

Review in cubic

Backend removed the restriction, so lift it also on the frontend
@nx-cloud

nx-cloud Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 05ef461

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 1m 15s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 47s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 28s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 2s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-10-02 15:23:58 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.55%. Comparing base (13dbccb) to head (05ef461).
⚠️ Report is 2 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3059      +/-   ##
===========================================
+ Coverage    46.75%   56.55%   +9.80%     
===========================================
  Files          147       43     -104     
  Lines         4825     1441    -3384     
  Branches      1510      469    -1041     
===========================================
- Hits          2256      815    -1441     
+ Misses        2221      442    -1779     
+ Partials       348      184     -164     
Flag Coverage Δ
unittests 56.55% <100.00%> (+9.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erebe
erebe merged commit 87151e5 into staging Oct 2, 2026
9 checks passed
@erebe
erebe deleted the erebe/storage branch October 2, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants