Secondary storage: work around 4k incompatibility, drop unnecessary luksFormat arguments
#1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default (sha256) seems fine for LUKS2 where the hash algorithm has a limited role anyway - it's not used for key stretching like in LUKS1.
rustybird
force-pushed
the
luksFormat-arguments
branch
from
b5e06f5 to
65e0511
Compare
|
The unrelated HTML-Proofer failures are already fixed in #1432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free not to take the second or third commit, it just looked a bit crowded to me.