GsonReader: Rethrow exceptions as Gson types #2
Conversation
Don't throw away the original exceptions entirely (they're now used as the cause of the wrapping exceptions) me: "I should follow ix0rai's advice and extract the exception wrapping code" also me: makes 5 separate helper functions for various return types
me: yeah I should do that |
There was a problem hiding this comment.
The performance gains by using per-type functions are unlikely to be worth the added maintenance cost of having 6 separate functions instead of a single one, please instead use DelegateFunction instead. (In addition creating a lambda invoker creates an object too - delegate::beginArray needs to store the delegate in a new object that implements DelegateAction)
For the void variant though you'll need to declare a second type that extends the first, like:
@FunctionalInterface
private interface DelegateAction extends DelegateFunction<Void> {
@Override
Void call() throws IOException {
run();
return null;
}
void run() throws IOException;
}
private void rethrowGsonExceptions(DelegateAction action) throws IOException {
rethrowGsonExceptions((DelegateFunction<Void>) action);
}As that way we can keep all the exception handling in one place?
(Alternatively you could call it rethrowGsonExceptionsVoid instead, to avoid the casting to select the right method).
Closes #1.