Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builtin date instead of querying meta #218

Merged
merged 2 commits into from
May 4, 2024

Conversation

TheEpicBlock
Copy link
Contributor

@TheEpicBlock TheEpicBlock commented May 4, 2024

Mojang has added a date field to the patch notes a while back, which should be more stable to use. There was a conversation about this a while back, meta takes longer to update causing new version to be sorted incorrectly. This also removes a network request


See preview on Cloudflare Pages: https://preview-218.quiltmc-org.pages.dev/

@Pyrofab
Copy link
Member

Pyrofab commented May 4, 2024

Is the date field available for all versions or only the most recent ones ?

@TheEpicBlock
Copy link
Contributor Author

It's available for all

Copy link
Contributor

@UpcraftLP UpcraftLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, using Mojang's own dates is a much better approach, now that it exists.

@ix0rai ix0rai added the enhancement New feature or request label May 4, 2024
@Pyrofab Pyrofab merged commit 788d3b7 into QuiltMC:main May 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants