Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gamemode] Teabag Confirmed #464

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

[Gamemode] Teabag Confirmed #464

wants to merge 17 commits into from

Conversation

x3Karma
Copy link
Contributor

@x3Karma x3Karma commented Jul 30, 2022

Wasn't going to PR this due to the extreme lack of interest, then I re-visited Macro's video and saw how many reactions the original server mod had, so decided to try and see if its good enough to make it in Northstar.

Original Discord Message.

How to Play

  • Dead players drop a battery upon death. It is highlighted according to team color. ( it also floats like minecraft items :O )
  • Teabag the battery and it will grant you a point if the player was of the opposing team.
  • It will just remove the battery and deny the enemy team from scoring if the battery was friendly.
  • yeah thats it

@x3Karma
Copy link
Contributor Author

x3Karma commented Jul 30, 2022

If you'd like to test the gamemode, here's the mod:
Teabag Confirmed.zip
( EDIT: Last Update 15/8/2022 )

@GeckoEidechse GeckoEidechse added gamemode Issues related to gamemodes, custom or vanilla needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code feedback wanted Feedback is wanted whether the changes by this PR are desired labels Aug 3, 2022
@GeckoEidechse
Copy link
Member

If you'd like to test the gamemode, here's the mod: Teabag Confirmed.zip.

Is https://northstar.thunderstore.io/package/x3Karma/TeabagConfirmed/ still up to date? Cause we could probably use that for easy setting up playtesting. ^^

@GeckoEidechse
Copy link
Member

Also maybe colouring batteries differently depending on enemy/friendly would be useful I think. At least I saw an awesome modder experiment with custom battery colours in modding-chat today :3

@x3Karma
Copy link
Contributor Author

x3Karma commented Aug 4, 2022

If you'd like to test the gamemode, here's the mod: Teabag Confirmed.zip.

Is https://northstar.thunderstore.io/package/x3Karma/TeabagConfirmed/ still up to date? Cause we could probably use that for easy setting up playtesting. ^^

Nah the thunderstore one isn't up to date, I did some formatting and updated some missing localization on this PR

@x3Karma
Copy link
Contributor Author

x3Karma commented Aug 4, 2022

Also maybe colouring batteries differently depending on enemy/friendly would be useful I think. At least I saw an awesome modder experiment with custom battery colours in modding-chat today :3

Not sure how that would work, I did gave them a different highlight depending on team but wouldn't changing colors of the batteries be visible to both teams and not team-dependant?

@GeckoEidechse
Copy link
Member

Also maybe colouring batteries differently depending on enemy/friendly would be useful I think. At least I saw an awesome modder experiment with custom battery colours in modding-chat today :3

Not sure how that would work, [...] wouldn't changing colors of the batteries be visible to both teams and not team-dependant?

Honestly I don't know. If that's the case and there isn't an easy way to change colour depending on team, then ofc it's not really feasible and can be skipped ^^

(Haven't checked out the friendly/enemy highlight yet, might just be enough)

global function CreateBattery

struct {
table<entity, float> players // needed for detecting if tbag grace period exceeded 3 seconds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these could probably be structs rather than individual tables per property, unless i'm misunderstanding this

Copy link
Contributor Author

@x3Karma x3Karma Aug 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this gamemode was done like all the way back 6 months ago when I was fairly new to scripting in Squirrel.

AFAIK now, I could totally use a struct for each individual player for more clarity but is there any downsides to the current tables method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a look again at this code, I honestly recommend keeping it this way because it would involve having to rewrite the entire thing from scratch.

@GeckoEidechse GeckoEidechse added the waiting on changes by author Waiting on PR author to implement the suggested changes label Aug 7, 2022
@GeckoEidechse GeckoEidechse removed the waiting on changes by author Waiting on PR author to implement the suggested changes label Aug 15, 2022
@x3Karma x3Karma requested a review from BobTheBob9 August 15, 2022 10:15
@uniboi
Copy link
Contributor

uniboi commented Nov 10, 2022

couldn't you just create a pickup like in the campaign? Stopping to tbag doesn't sounds like it takes speed out of the game

@x3Karma
Copy link
Contributor Author

x3Karma commented Nov 11, 2022

couldn't you just create a pickup like in the campaign? Stopping to tbag doesn't sounds like it takes speed out of the game

I mean, the funny part is watching the killer teabag you in the first place, otherwise it would just be, idk, Headhunter?

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than formatting, code looks good

(although I don't think this PR is going to get worked on is it?)

@GeckoEidechse
Copy link
Member

Same with as with Hot Potato, with progress on auto-mod-download, I think this is one of the gamemodes that should get verified via VerifiedMods repo so that players can auto-download it on server join :D

@GeckoEidechse
Copy link
Member

@x3Karma marking this as draft instead of closing so I can keep track of it until it's submitted for verification via https://github.com/R2Northstar/VerifiedMods/

I see you already uploaded a version to thunderstore via https://thunderstore.io/c/northstar/p/x3Karma/TeabagConfirmed/ so all that's missing is maybe some small cleanup and then it should get verified pretty fast and released via MAD :D

@GeckoEidechse GeckoEidechse marked this pull request as draft August 14, 2024 15:30
@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code feedback wanted Feedback is wanted whether the changes by this PR are desired labels Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gamemode Issues related to gamemodes, custom or vanilla
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants