-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gamemode] Teabag Confirmed #464
base: main
Are you sure you want to change the base?
Conversation
fixed not showing Auto-Titans death in killfeed
If you'd like to test the gamemode, here's the mod: |
Is https://northstar.thunderstore.io/package/x3Karma/TeabagConfirmed/ still up to date? Cause we could probably use that for easy setting up playtesting. ^^ |
Also maybe colouring batteries differently depending on enemy/friendly would be useful I think. At least I saw an awesome modder experiment with custom battery colours in modding-chat today :3 |
Nah the thunderstore one isn't up to date, I did some formatting and updated some missing localization on this PR |
Not sure how that would work, I did gave them a different highlight depending on team but wouldn't changing colors of the batteries be visible to both teams and not team-dependant? |
Honestly I don't know. If that's the case and there isn't an easy way to change colour depending on team, then ofc it's not really feasible and can be skipped ^^ (Haven't checked out the friendly/enemy highlight yet, might just be enough) |
Northstar.Custom/mod/scripts/vscripts/gamemodes/cl_gamemode_tbag.nut
Outdated
Show resolved
Hide resolved
global function CreateBattery | ||
|
||
struct { | ||
table<entity, float> players // needed for detecting if tbag grace period exceeded 3 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these could probably be structs rather than individual tables per property, unless i'm misunderstanding this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this gamemode was done like all the way back 6 months ago when I was fairly new to scripting in Squirrel.
AFAIK now, I could totally use a struct for each individual player for more clarity but is there any downsides to the current tables method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a look again at this code, I honestly recommend keeping it this way because it would involve having to rewrite the entire thing from scratch.
couldn't you just create a pickup like in the campaign? Stopping to tbag doesn't sounds like it takes speed out of the game |
I mean, the funny part is watching the killer teabag you in the first place, otherwise it would just be, idk, Headhunter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than formatting, code looks good
(although I don't think this PR is going to get worked on is it?)
Same with as with Hot Potato, with progress on auto-mod-download, I think this is one of the gamemodes that should get verified via VerifiedMods repo so that players can auto-download it on server join :D |
@x3Karma marking this as draft instead of closing so I can keep track of it until it's submitted for verification via https://github.com/R2Northstar/VerifiedMods/ I see you already uploaded a version to thunderstore via https://thunderstore.io/c/northstar/p/x3Karma/TeabagConfirmed/ so all that's missing is maybe some small cleanup and then it should get verified pretty fast and released via MAD :D |
Wasn't going to PR this due to the extreme lack of interest, then I re-visited Macro's video and saw how many reactions the original server mod had, so decided to try and see if its good enough to make it in Northstar.
Original Discord Message.
How to Play