-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong Item Type for Titan Camos #728
Fix wrong Item Type for Titan Camos #728
Conversation
Why must respawn use different item types for copies of the same item i may never know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, can't test though for the next few days so yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't really reproduce the bug in testing. @Zanieon suggested to disable progression, select a Titan camo that would not yet be unlocked, enabled progression again and the Titan would keep the locked camo.
That however didn't really happen for me. Both with and without the PR, the Titan would always switch back to a the default camo if the previously set camo was a locked one.
I'm gonna leave this to you @ASpoonPlaysGames ^^
Merging based on @ASpoonPlaysGames' review ig |
Split from #726
Small fix which the wrong item type was being addressed to check for Titan Camos, allowing players to use any camo without fallback to default if they didn't own that item previously when enabling progression.