Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 add accordion icons to intro tab #150

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Dec 10, 2024

Closes #131
Closes #141
Supersedes #139

@jdhoffa jdhoffa requested a review from MonikaFu as a code owner December 10, 2024 08:58
@jdhoffa jdhoffa requested a review from AlexAxthelm December 10, 2024 08:58
Copy link

github-actions bot commented Dec 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-10 09:21 UTC

Copy link

Docker build status

commit_time git_sha image
2024-12-10T08:58:23Z d0b9dd2 ghcr.io/rmi-pacta/pacta-dashboard-svelte:pr-150

Copy link
Contributor

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically approve, but observing what might be an unexpected behavior:

Exactly one accordion drop-down can be open at a time. That is, when I open a drop, I can't roll it back up, and it closes all others (there's no way to see all text on the page at the same time).

@jdhoffa
Copy link
Member Author

jdhoffa commented Dec 10, 2024

Technically approve, but observing what might be an unexpected behavior:

Exactly one accordion drop-down can be open at a time. That is, when I open a drop, I can't roll it back up, and it closes all others (there's no way to see all text on the page at the same time).

That is actually intentional! It is defined by the autocollapse param. Hodie seemed to be in favour of it, however @MonikaFu has also flagged that it seems awkward....

That said, we might just be ditching this section altogether so I'm not going to think too much about it 😅

@jdhoffa jdhoffa merged commit 5419681 into main Dec 10, 2024
11 checks passed
@jdhoffa jdhoffa deleted the 131-add_accordion_icons branch December 10, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instruction Page Missing Icons 🎨 add icons to accordion menu
2 participants