Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger plot drawing and selectors update only after Go! is clicked #174

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

MonikaFu
Copy link
Contributor

@MonikaFu MonikaFu commented Jan 10, 2025

Solves #168

FYI @cjyetman

Copy link

github-actions bot commented Jan 10, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-14 11:39 UTC

Copy link

github-actions bot commented Jan 10, 2025

Docker build status

commit_time git_sha image
2025-01-13T14:54:25Z a3a4fdb ghcr.io/rmi-pacta/pacta-dashboard-svelte:pr-174

@MonikaFu MonikaFu marked this pull request as ready for review January 10, 2025 13:56
@MonikaFu MonikaFu requested review from jdhoffa and cjyetman and removed request for cjyetman January 10, 2025 13:56
@cjyetman
Copy link
Member

not sure if this new or if it's a related problem, but...

  1. go to preview site
  2. click on "Sector-level Analysis" tab
  3. select Steel from the first drop down selector
  4. click "Go!"
  5. note the lack of any data in the emissions timeline plot
  6. select "Automotive" from first drop down selector
  7. select "Listed Equity" from second drop down selector
  8. select "Steel" from first drop down selector
  9. select "Corporate Bonds" from second drop down selector
  10. note that there is now data for Steel-Corporate Bonds-Emissions

@cjyetman
Copy link
Member

similarly...

  1. go to preview site
  2. click on "Sector-level Analysis" tab
  3. select Steel from the first drop down selector
  4. click "Go!"
  5. select "WEO2023" as scenario source
  6. select "NZE_2050" as scenario
  7. note that there are no selectable options for "Allocation Method" (and no data in emissions timeline)

@jdhoffa
Copy link
Member

jdhoffa commented Jan 10, 2025

not sure if this new or if it's a related problem, but...

  1. go to preview site
  2. click on "Sector-level Analysis" tab
  3. select Steel from the first drop down selector
  4. click "Go!"
  5. note the lack of any data in the emissions timeline plot
  6. select "Automotive" from first drop down selector
  7. select "Listed Equity" from second drop down selector
  8. select "Steel" from first drop down selector
  9. select "Corporate Bonds" from second drop down selector
  10. note that there is now data for Steel-Corporate Bonds-Emissions

This behavior does not appear on main, and seems to have been introduced by this PR.

@jdhoffa
Copy link
Member

jdhoffa commented Jan 10, 2025

similarly...

  1. go to preview site
  2. click on "Sector-level Analysis" tab
  3. select Steel from the first drop down selector
  4. click "Go!"
  5. select "WEO2023" as scenario source
  6. select "NZE_2050" as scenario
  7. note that there are no selectable options for "Allocation Method" (and no data in emissions timeline)

This also isn't happening on main.

@MonikaFu
Copy link
Contributor Author

Thanks @cjyetman! Indeed, fixing one bug exposed another bug. Wrong name was used for 'sector' variable when filtering emission intensity data therefore no options for selection could be drawn. I believe now both cases you identified are fixed.

@MonikaFu MonikaFu merged commit 7baaed9 into main Jan 14, 2025
11 checks passed
@MonikaFu MonikaFu deleted the 168-solve-bug-selector-sector branch January 14, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants