feat: adapt and pass through FPRE real estate data from user_results into 50_Outputs
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhoffa
commented
Sep 26, 2024
jdhoffa
changed the title
user_results into 50_Outputs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
========================================
- Coverage 0.81% 0.80% -0.02%
========================================
Files 25 25
Lines 1596 1617 +21
========================================
Hits 13 13
- Misses 1583 1604 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Was causing error, as an empty argument
2 tasks
|
FYI @AlexAxthelm I can't actually approve this as it's my own PR, but looks great to me, thank you! |
|
Thanks. Holding on merging until https://github.com/RMI-PACTA/templates.transition.monitor/pull/34 is approved |
AlexAxthelm
added a commit
to RMI-PACTA/workflow.transition.monitor
that referenced
this pull request
Oct 22, 2024
Not to be merged until dependencies are resolved. Updates build configuration to use latest version of testing RE files. Depends On: - [ ] RMI-PACTA/pacta.portfolio.report#93 - [ ] RMI-PACTA/templates.transition.monitor#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to
create_interactive_reportto handle new Real Estate reports from FPRE. Looks forreports.json, and prepares summary table to be passed to template.Requires coordination with: https://github.com/RMI-PACTA/templates.transition.monitor/pull/34
See RMI-PACTA/workflow.transition.monitor#361 for latest rendered version.