Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefID to support garbage collection of objects #100

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

RT-nilPointer
Copy link

Description

Keeps track of RefIDs for the detection of objects and updating of buckets.

The root of RefIDs is generated from a local secret, a malicious user with access to this secret can cause data loss.

Motivation and Context

Support the missing deletion of content on the backend.

How to test this PR?

Need the latest TemporalX backend with RefID support

@github-actions
Copy link

github-actions bot commented Nov 4, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@RT-nilPointer RT-nilPointer marked this pull request as draft November 4, 2020 08:49
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #100 (db87506) into master (64fd9b4) will increase coverage by 0.22%.
The diff coverage is 71.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   67.78%   68.01%   +0.22%     
==========================================
  Files          15       16       +1     
  Lines         950      991      +41     
==========================================
+ Hits          644      674      +30     
- Misses        201      206       +5     
- Partials      105      111       +6     
Impacted Files Coverage Δ
gateway/s3x/bucket_locker.go 100.00% <ø> (ø)
gateway/s3x/refid.go 54.54% <54.54%> (ø)
gateway/s3x/ipfs.go 64.15% <88.88%> (+1.77%) ⬆️
gateway/s3x/ledger_bucket.go 74.54% <100.00%> (ø)
gateway/s3x/ledger_store.go 75.00% <100.00%> (+0.33%) ⬆️
gateway/s3x/multipart.go 55.04% <100.00%> (ø)
gateway/s3x/object.go 72.59% <100.00%> (ø)
gateway/s3x/s3x.go 69.23% <100.00%> (ø)
gateway/s3x/crdt_broadcaster.go 86.66% <0.00%> (+4.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fd9b4...db87506. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant