Log on failure #23
Merged
Log on failure #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcraybould
approved these changes
Apr 20, 2018
jillh510
requested changes
Apr 23, 2018
sync/views.py
Outdated
|
|
||
| return_status, result_string = knackload.load(json.dumps(knack_value)) | ||
|
|
||
| if return_status != 200: | ||
| print('Error: We failed to send {} to knack'.format(knack_value)) | ||
| contribution_refcode = knack_value['field_638'] |
There was a problem hiding this comment.
'field_638' is the date. Please log the order_id from ActBlue instead.
There was a problem hiding this comment.
Also, this code will crash in debug mode because those fields won't exist in knack_value.
jillh510
requested changes
Apr 24, 2018
sync/views.py
Outdated
|
|
||
| error_msg = 'Error: We failed to send order {}, lineitem {} to knack' | ||
| print(error_msg.format(order_id, lineitem_entity_id)) | ||
| log_debug('Error: We failed to send ' + knack_value) |
kcraybould
approved these changes
Apr 24, 2018
jillh510
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jillh510, as per #3, this does not do any clever retry logic, but logs the failure and returns a 500.