chore: update github pages for plugins - #2764
Conversation
|
Actions test run passed here: https://github.com/lizschwab/blockly-samples/actions/runs/33915266290 |
| default: 'main' | ||
| type: string | ||
| core_branch: | ||
| description: 'Blockly core branch to publish from (for plugins)' |
There was a problem hiding this comment.
I think with the way you're passing this in, it can also be a tag right? I think the default should be leaving this blank and having it use the latest published version of the plugins (so if the user didn't specify a branch/tag, you'd add a step finding the most recent git tag and use that as the checkout ref) because main may contain unreleased changes. but this could be a follow-up issue because this is really a feature request on top of this PR
| "deploy:prepare": "npm run deploy:prepare:plugins && npm run deploy:prepare:examples && gulp predeploy", | ||
| "deploy:prepare:examples": "npm install --workspace=examples && npm run prepare-examples && npm run predeploy --if-present --workspace=examples", | ||
| "deploy:prepare:plugins": "npm run clean && npm run build && lerna run predeploy --scope '@blockly/*'", | ||
| "deploy:prepare:plugins": "cd ../blockly && npx nx reset && lerna run clean --scope '@blockly/*' && lerna run build --scope '@blockly/*' && lerna run predeploy --scope '@blockly/*'", |
There was a problem hiding this comment.
This is kind of sketchy to me because it presupposes that blockly is at ../blockly and there's no inherent reason that must be true (especially when running locally, but could also get out of sync if the workflow file ever changed the checkout location). I think these steps might belong in the workflow file itself for deploying on CI. and deploying locally might need some other solution
There was a problem hiding this comment.
Created an issue for the local side of this: #2766
| steps: | ||
| - name: Checkout | ||
| - name: Checkout Blockly-Samples | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
may be worth updating the version of the checkout command action while you're here, i think they're on 4 or 5 now
|
Re-run of workflow with latest changes: https://github.com/lizschwab/blockly-samples/actions/runs/34411366725/job/102666288922 |
3 participants
The details
Resolves
Fixes #7767
Proposed Changes
This updates the Blockly-Samples github pages to pull in the code from the core repo but still host on blockly-samples. There are no changes to how examples are hosted or built.
Reason for Changes
The plugins have moved to core, so we need to pull the code from there rather than from the stale and soon-to-be-deleted directory on the samples repo.