Remove unnecessary this capture for subjectss

ReactiveX · Nov 3, 2021 · 9075876 · 9075876
1 parent ec38393
commit 9075876
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Rx/v2/src/rxcpp/subjects/rx-behavior.hpp b/Rx/v2/src/rxcpp/subjects/rx-behavior.hpp
@@ -91,11 +91,11 @@ class behavior
 
     observable<T> get_observable() const {
         auto keepAlive = s;
-        return make_observable_dynamic<T>([keepAlive, this](subscriber<T> o){
+        return make_observable_dynamic<T>([keepAlive](subscriber<T> o){
             if (keepAlive.get_subscription().is_subscribed()) {
-                o.on_next(get_value());
+                o.on_next(keepAlive.get_value());
             }
-            keepAlive.add(s.get_subscriber(), std::move(o));
+            keepAlive.add(keepAlive.get_subscriber(), std::move(o));
         });
     }
 };

diff --git a/Rx/v2/src/rxcpp/subjects/rx-replaysubject.hpp b/Rx/v2/src/rxcpp/subjects/rx-replaysubject.hpp
@@ -169,8 +169,8 @@ class replay
 
     observable<T> get_observable() const {
         auto keepAlive = s;
-        auto observable = make_observable_dynamic<T>([keepAlive, this](subscriber<T> o){
-            for (auto&& value: get_values()) {
+        auto observable = make_observable_dynamic<T>([keepAlive](subscriber<T> o){
+            for (auto&& value: keepAlive.get_values()) {
                 o.on_next(value);
             }
             keepAlive.add(keepAlive.get_subscriber(), std::move(o));