CherryPicked: [cnv-4.22] Fix observability metrics test failures (#6219) by OhadRevah · Pull Request #6340 · RedHatQE/openshift-virtualization-tests

OhadRevah · 2026-09-17T07:32:37Z

What this PR does / why we need it:

Cherry-pick from main branch, original PR: #6219

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

https://redhat.atlassian.net/browse/CNV-97760

Replace redundant virt-handler pod curl with Prometheus-based label validation. The direct curl was a single-shot check with no retry on conditionally-emitted metrics (e.g. storage_flush_requests_total), and the same metric pipeline is already validated via Prometheus query. Label validation (node, namespace) now runs on the Prometheus response. Fix fixture ordering in TestVmiSyncTotal by adding usefixtures for initial_vmi_sync_total_values on the first incremental test, ensuring the baseline is captured before migration fixtures run. assisted by: claude code claude-opus-4-6 https://redhat.atlassian.net/browse/CNV-96787  - **Tests** - Updated VM metrics tests to validate node and namespace labels directly from Prometheus results. - Added initial synchronization value setup to the VMI synchronization metrics test. - Consolidated metrics validation coverage around label-based checks, removing reliance on virt-handler pod metric retrieval.  Signed-off-by: Ohad <orevah@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-09-17T07:32:44Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (5)

main
cnv-4.21
cnv-4.20
cnv-4.19
cnv-4.18

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 64f41484-f3bd-4ea5-83b1-5cea2e625483

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-virtualization-qe-bot · 2026-09-17T07:33:11Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (PR author or approvers)
/hold cancel - Unblock PR merging (PR author or approvers)
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message
/security-override - Set security check runs to pass (maintainers only)
/security-override cancel - Re-run security checks

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest verify-bugs-are-open - verify-bugs-are-open
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3
/cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

/rebase - Rebase this PR branch onto its base branch

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

dshchedr
myakove
rnetser
vsibirsk

Reviewers:

OhadRevah
RoniKishner
albarker-rh
dshchedr
hmeir
rlobillo
rnetser
vsibirsk

Available Labels

hold
verified
wip
lgtm
approve

AI Features

Cherry-Pick Conflict Resolution: Enabled (cursor/cursor-grok-4.6-low)

Security Checks

Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
Committer Identity Check: Verifies last committer matches PR author
Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

📌 Additional Information

Custom Commands:

/test-plan — Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan
/rerun-smoke — Adds retest-smoke label on the PR to trigger smoke tests execution

For more information, please refer to the project documentation or contact the maintainers.

OhadRevah · 2026-09-17T08:19:18Z

/retest verify-bugs-are-open

github-actions Bot added the sig-iuo label Sep 17, 2026

OhadRevah changed the title ~~Fix observability metrics test failures (#6219)~~ CherryPicked: [cnv-4.22] Fix observability metrics test failures (#6219) Sep 17, 2026

openshift-virtualization-qe-bot requested a review from albarker-rh September 17, 2026 07:33

openshift-virtualization-qe-bot assigned OhadRevah Sep 17, 2026

openshift-virtualization-qe-bot requested a review from rlobillo September 17, 2026 07:33

openshift-virtualization-qe-bot mentioned this pull request Sep 17, 2026

CherryPicked: [cnv-4.22] Fix observability metrics test failures (#6219) - 6340 #6341

Open

openshift-virtualization-qe-bot added the branch-cnv-4.22 label Sep 17, 2026

openshift-virtualization-qe-bot requested a review from vsibirsk September 17, 2026 07:33

openshift-virtualization-qe-bot added the size/L label Sep 17, 2026

openshift-virtualization-qe-bot requested review from hmeir and rnetser September 17, 2026 07:33

openshift-virtualization-qe-bot added the tox:verify-tc-requirement-polarion:running D/S Testing label Sep 17, 2026

openshift-virtualization-qe-bot requested review from RoniKishner and dshchedr September 17, 2026 07:34

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:passed D/S Testing and removed tox:verify-tc-requirement-polarion:running D/S Testing labels Sep 17, 2026

Navigation Menu

CherryPicked: [cnv-4.22] Fix observability metrics test failures (#6219) - #6340

CherryPicked: [cnv-4.22] Fix observability metrics test failures (#6219)#6340
OhadRevah wants to merge 1 commit into
RedHatQE:cnv-4.22from
OhadRevah:fix-observability-lane-failures-cnv-4.22

OhadRevah commented Sep 17, 2026

Uh oh!

coderabbitai Bot commented Sep 17, 2026

Review skipped

Uh oh!

openshift-virtualization-qe-bot commented Sep 17, 2026

Uh oh!

OhadRevah commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

OhadRevah commented Sep 17, 2026

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Uh oh!

coderabbitai Bot commented Sep 17, 2026

Review skipped

Uh oh!

openshift-virtualization-qe-bot commented Sep 17, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Branch Management

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

📌 Additional Information

Uh oh!

OhadRevah commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants