update conversion tools and their tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
@yibeichan - I've checked that the tests work for me and the output is created this time. Perhaps we can just merge this and I will try to change the code to use the classes from |
|
okay, merged! let's see how it goes once you change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
reproschema2redcapandredcap2reproschemaand corresponding testsThe
redcap2reproschemaone has the most updates, thanks to Evan's feedback on thebridge2aiconversion@djarecka based on Friday's discussion, I added more checks/assertions in the tests; also moved test outputs to
tmpdirAfter you review this PR, we can talk about what else needs to be improved.