Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 3.7, add 3.11 & 3.12 #38

Merged
merged 7 commits into from
May 2, 2024
Merged

remove 3.7, add 3.11 & 3.12 #38

merged 7 commits into from
May 2, 2024

Conversation

yibeichan
Copy link
Contributor

python 3.7 kept failing GA with the following error:

Run actions/setup-python@v2
  with:
    python-version: [3](https://github.com/ReproNim/reproschema-py/actions/runs/8881434819/job/24383768417#step:3:3).7
    token: ***
Version 3.7 was not found in the local cache
Error: Version 3.7 with arch arm6[4](https://github.com/ReproNim/reproschema-py/actions/runs/8881434819/job/24383768417#step:3:4) not found

I guess it's time to say goodbye

@satra
Copy link
Contributor

satra commented Apr 29, 2024

add 3.12 as well

@yibeichan yibeichan changed the title remove 3.7, add 3.11 remove 3.7, add 3.11 & 3.12 Apr 29, 2024
@yibeichan
Copy link
Contributor Author

okay great, 3.11 was okay but 3.12 failed. it seems that we need to fix something

@Remi-Gau
Copy link
Contributor

error seems related to this (versioneer related)

pydata/pandas-datareader#969

My 2 cents: stick to 3.11 in this PR, modernize the packaging (pyproject.toml + build with hatchling-vcs to drop versionner) and support 3.12

@Remi-Gau
Copy link
Contributor

modernize the packaging (pyproject.toml + build with hatchling-vcs to drop versionner)

I can take care of this

@yibeichan
Copy link
Contributor Author

modernize the packaging (pyproject.toml + build with hatchling-vcs to drop versionner)

I can take care of this

sounds good! removed 3.12. I don't even know what "hatchling-vcs to drop versionner" means

@satra
Copy link
Contributor

satra commented Apr 30, 2024

perhaps just follow the versioneer steps in their readme. i think that should work to update versioneer quite easily. also may need to update version of auto in the github workflows.

@yibeichan
Copy link
Contributor Author

yay, updated versioneer works. i'm going to merge this one

@yibeichan yibeichan merged commit b227e12 into master May 2, 2024
11 checks passed
@yibeichan yibeichan deleted the enh/py-version branch May 2, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants