Fix lost click event when opening popup

Revolutionary-Games · Jan 7, 2025 · 9e70e8a · 9e70e8a
1 parent 6e9ffb1
commit 9e70e8a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/engine/input/RunOnKeyDownAttribute.cs b/src/engine/input/RunOnKeyDownAttribute.cs
@@ -18,8 +18,11 @@ public RunOnKeyDownAttribute(string inputName) : base(inputName)
 
     public override bool OnInput(InputEvent @event)
     {
-        var before = HeldDown;
-        if (base.OnInput(@event) && !before && HeldDown)
+        // Only trigger if the input was pressed this frame. It isn't possible to use !HeldDown since its value is
+        // incorrect if a mouse release event is marked as handled e.g. when opening a popup.
+        // https://github.com/Revolutionary-Games/Thrive/issues/5217
+        var justPressed = Input.IsActionJustPressed(InputName);
+        if (base.OnInput(@event) && justPressed && HeldDown)
         {
             if (TrackInputMethod)
             {