Fix YAML import and handle optional configuration values - #461
Merged
Merged
Conversation
RobHofmann
approved these changes
Sep 16, 2026
RobHofmann
left a comment
Owner
There was a problem hiding this comment.
Tested against a real device on a dev instance: the YAML import creates the config entry automatically, test_connection runs first and succeeds, and the YAML mode lists carry through into the entry data. On a second restart the flow aborts on the already-configured unique ID without a further connection attempt, so no duplicate entry and no wasted network round trip per device.
Merging. Two small follow-ups, neither blocking: cannot_connect has no string under config.abort (only under config.error), and the setdefault calls for port and encryption_version are redundant since the YAML schema already defaults both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes YAML-based configuration imports.
The integration currently declares a YAML configuration schema and documents YAML configuration in the README, however
async_step_import()forwards directly toasync_step_user(), causing imported entries to stop at the manual configuration step instead of creating config entries automatically.Additionally,
test_connection()expects optional fields such asencryption_keyanduidto be present, resulting in:when using the documented YAML configuration examples.
Changes
async_step_import()Tested
Tested successfully on Home Assistant 2026.6.1 with multiple Gree units defined through YAML configuration.
The following configuration imports correctly and creates config entries automatically: