Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix gcc15 issues - #10

Merged
JaceCear merged 4 commits into
SAT-R:mainfrom
bitten2up:gcc15-fixes
Nov 18, 2025
Merged

JaceCear merged 4 commits into
SAT-R:mainfrom
bitten2up:gcc15-fixes

Conversation

@bitten2up

Copy link
Copy Markdown
Contributor

adds two flags (-std=c11 and -Wno-incompatible-pointer-types)' to prevent compiler errors on gcc 15

In file included from arena_alloc.c:24:
types.h:8:21: error: ‘bool’ cannot be defined via ‘typedef’
    8 | typedef signed char bool;
      |                     ^~~~

(this one is sdl exclusive)

src/lib/m4a/m4a.c: In function ‘MPlayExtender’:
src/lib/m4a/m4a.c:266:24: error: assignment to ‘MPlayFunc’ {aka ‘void (*)(void)’} from incompatible pointer type ‘void (*)(struct MP2KPlayerState *, struct MP2KTrack *)’ [-Wincompatible-pointer-types]
  266 |     gMPlayJumpTable[8] = MP2K_event_memacc;

Comment thread Makefile Outdated
CC1FLAGS += -Wstrict-overflow=1
ifeq ($(PLATFORM),sdl)
CC1FLAGS += -Wno-parentheses-equality -Wno-unused-value
CC1FLAGS += -Wno-parentheses-equality -Wno-unused-value -Wno-incompatible-pointer-types

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning should not be removed, I think.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include/lib/m4a/m4a_internal.h:extern MPlayFunc gMPlayJumpTable[];
is
include/lib/m4a/m4a_internal.h:extern void *gMPlayJumpTable[];
in SA2, feel free to adjust that.
As well as
src/lib/m4a/m4a.c:EWRAM_DATA void *gMPlayJumpTable[36] = {};

@JaceCear JaceCear left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@JaceCear
JaceCear merged commit af39a9b into SAT-R:main Nov 18, 2025
7 of 13 checks passed
github-actions Bot pushed a commit that referenced this pull request Nov 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants