Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample table links unaware of subpath #74

Open
alkc opened this issue Oct 13, 2023 · 2 comments · Fixed by #76
Open

Sample table links unaware of subpath #74

alkc opened this issue Oct 13, 2023 · 2 comments · Fixed by #76
Assignees
@mhkc
Labels
bug Something isn't working frontend Front end related issues and features

Comments

@alkc
Copy link
Contributor

alkc commented Oct 13, 2023

Describe the bug

bild

The code generating the sample list in /groups is unaware of bonsai client being proxied/hosted at a subpath when bonsai client is deployed as such

In the picture above the linked sample URL is http://mtlucmds1.lund.skane.se/samples/MT21000044-v2 while it should be http://mtlucmds1.lund.skane.se/bonsai/samples/MT21000044-v2

Additional context

Deployed with gunicorn with -e SCRIPT_NAME /bonsai/
@alkc alkc added bug Something isn't working frontend Front end related issues and features labels Oct 13, 2023
@mhkc
Copy link
Contributor

mhkc commented Oct 16, 2023

The problem is caused by the javascript function that formtats the sample id was not designed for this type of hosting solution.

One option would be to use set the variable SCRIPT_ROOT variable in the flask templates.

See, https://flask.palletsprojects.com/en/2.3.x/patterns/javascript/

@mhkc mhkc self-assigned this Oct 16, 2023
@mhkc mhkc mentioned this issue Oct 16, 2023
Merged
@mhkc mhkc linked a pull request Oct 16, 2023 that will close this issue
Include SCRIPT_ROOT in URL creattion w JS #76
Merged
@alkc alkc closed this as completed in #76 Oct 16, 2023
@ryanjameskennedy
Copy link
Contributor

This is the same problem we're having now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhkc mhkc

Labels
bug Something isn't working frontend Front end related issues and features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include SCRIPT_ROOT in URL creattion w JS SMD-Bioinformatics-Lund/bonsai
3 participants
@mhkc @alkc @ryanjameskennedy