✨ 364 Add Vogen for Strongly Typed IDs #441
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#364
This pull request includes several changes aimed at refactoring the codebase to use strongly typed IDs and improving the configuration of the Entity Framework Core (EF Core) models. The most important changes include the introduction of the
Vogen
library for value objects, updates to theHeroId
,TeamId
, andMissionId
types, and adjustments to the entity configurations.Refactoring to use strongly typed IDs:
src/Domain/Heroes/Hero.cs
: Replaced theHeroId
struct with aVogen
value object and updated theCreate
method to useHeroId.From
. [1] [2]src/Domain/Teams/Mission.cs
: Replaced theMissionId
struct with aVogen
value object and updated theCreate
method to useMissionId.From
. [1] [2]src/Domain/Teams/Team.cs
: Replaced theTeamId
struct with aVogen
value object and updated theCreate
method to useTeamId.From
. [1] [2]Entity Framework Core configuration updates:
src/Infrastructure/Persistence/ApplicationDbContext.cs
: Added theRegisterAllInVogenEfCoreConverters
method call inConfigureConventions
to register the Vogen converters.src/Infrastructure/Persistence/Configuration/HeroConfiguration.cs
,MissionConfiguration.cs
,TeamConfiguration.cs
: Commented out the manual conversions forHeroId
,MissionId
, andTeamId
as they are now handled by Vogen's EF Core converters. [1] [2] [3]Additional changes:
src/Domain/Domain.csproj
: Added theVogen
package reference.tests/Domain.UnitTests/Heroes/HeroTests.cs
,MissionTests.cs
,TeamTests.cs
: Updated tests to use theHeroId.From
,MissionId.From
, andTeamId.From
methods. [1] [2] [3] [4]No