Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 431 enhanced problem details #443

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

danielmackay
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

#431

  1. What was changed?

This pull request includes several changes to improve the handling of exceptions and API references in the WebApi project, as well as updates to ADR documentation statuses. The most important changes are grouped by theme below:

Documentation Updates:

  • Updated the status of ADR documents from "approved" to "accepted" to reflect the current decision status. (docs/adr/20241118-produce-useful-sql-server-exceptions.md, docs/adr/20241118-replace-automapper-with-manual-mapping.md, docs/adr/20241118-use-vogen-to-simplify-strongly-typed-ids.md) [1] [2] [3]

Exception Handling Improvements:

  • Added a new extension method AddCustomProblemDetails in CustomProblemDetailsExt.cs to customize problem details in HTTP responses. (src/WebApi/Extensions/CustomProblemDetailsExt.cs)
  • Updated Program.cs to use the new AddCustomProblemDetails method instead of the default AddProblemDetails method. (src/WebApi/Program.cs)

API Reference Mapping:

  • Added a new extension method MapCustomScalarApiReference in CustomScalarExt.cs to map Scalar API references with a default HTTP client. (src/WebApi/Extensions/CustomScalarExt.cs)
  • Updated Program.cs to use the new MapCustomScalarApiReference method instead of directly mapping Scalar API references. (src/WebApi/Program.cs)
  1. Did you do pair or mob programming?

No

@danielmackay danielmackay linked an issue Nov 18, 2024 that may be closed by this pull request
@AntPolkanov AntPolkanov merged commit 6233f2f into main Nov 18, 2024
2 checks passed
@AntPolkanov AntPolkanov deleted the 431--enhanced-problem-details branch November 18, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhanced Problem Details
2 participants