Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release preview of v2.9.0 of PWA Kit (@W-17624115@) #2211

Open
wants to merge 2 commits into
base: release-2.9.x
Choose a base branch
from
Open

Release preview of v2.9.0 of PWA Kit (@W-17624115@) #2211

wants to merge 2 commits into from

Conversation

joeluong-sfcc
Copy link
Collaborator

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@joeluong-sfcc
Support Node 20 in v2 of PWA Kit - @W-17543953@ (#2189)
cc792ff 
* test v2 ci

* modify bootstrap.js

* update test.yml

* revert changes

* remove install system dep steps and check-dependencies.js check

* skip test

* upgrade lighthouse dep to match v3

* add comment

* bump version

* pass channel_id to SLAS

* add datadog install to workflow

* fix test

* bump version and update changelogs

* update engines section in package.json

* update CI to include node 20 and npm 10

* update package-lock.json

* update exclude

* exclude node 14 npm 10

* remove comments and add back in check dependency script

* change version number

* update babel configs

* remove comment
vmarta
vmarta approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@vmarta vmarta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I see all packages versioned at: v2.9.0-preview.0 👍

@joeluong-sfcc joeluong-sfcc marked this pull request as ready for review January 17, 2025 20:58
@joeluong-sfcc joeluong-sfcc requested a review from a team as a code owner January 17, 2025 20:58
@joeluong-sfcc joeluong-sfcc changed the title Release v2.9.0 of PWA Kit (@W-17624115@) Release preview of v2.9.0 of PWA Kit (@W-17624115@) Jan 17, 2025
vcua-mobify
vcua-mobify approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@vcua-mobify vcua-mobify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To summarize the changes in this release, they are:

  • Node 20 upgrade
  • Adding channel_id to SLAS calls
  • Fixing CC expiry on tests
  • Datadog setup in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcua-mobify vcua-mobify vcua-mobify approved these changes

@vmarta vmarta vmarta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joeluong-sfcc @vmarta @vcua-mobify