feat: upgrade to Appwrite version 15 and updated website code #356
Conversation
|
@pahuja-sahil is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @pahuja-sahil! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
|
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (2)
You can disable this status message by setting the WalkthroughThe recent updates primarily enhance the authentication API by refining method calls for account sessions and integrating OAuth provider constants. Additionally, the user details type is extended to include an optional Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant Frontend
participant Backend
participant Appwrite
User->>Frontend: Login with Email/Password
Frontend->>Backend: POST /login (email, password)
Backend->>Appwrite: createEmailPasswordSession(email, password)
Appwrite-->>Backend: Session Data
Backend-->>Frontend: Session Data
Frontend-->>User: Login Successful
User->>Frontend: Login with GitHub
Frontend->>Backend: POST /login/github
Backend->>Appwrite: createOAuth2Session(OAuthProvider.Github, ...)
Appwrite-->>Backend: OAuth Session Data
Backend-->>Frontend: OAuth Session Data
Frontend-->>User: Login Successful
This diagram illustrates the updated authentication flow for both email/password and GitHub OAuth logins. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
package.jsonis excluded by!**/*.jsonyarn.lockis excluded by!**/*.lock,!**/*.lock
Files selected for processing (2)
- src/backend/auth.api.ts (5 hunks)
- src/types/auth.d.ts (1 hunks)
Additional comments not posted (5)
src/backend/auth.api.ts (5)
4-4: The addition ofOAuthProvideris necessary for the updated OAuth session creation method.
148-148: The update to usecreateEmailPasswordSessionfor login is consistent with the new Appwrite API.
290-290: UsingOAuthProvider.Githubinstead of a string literal enhances type safety and aligns with the new Appwrite API.
34-34: The update to usecreateEmailPasswordSessionaligns with the new Appwrite API. Ensure robust error handling for session creation failures.#!/bin/bash # Description: Verify error handling for session creation in `register` function. # Test: Search for error handling patterns. Expect: Proper error handling around session creation. rg --type python $'createEmailPasswordSession'
206-206: Removing theconfirmpasswordparameter simplifies the API and enhances security. Consider a security audit to ensure this change is properly integrated.#!/bin/bash # Description: Verify the security implications of removing `confirmpassword`. # Test: Search for security audits related to password handling. Expect: Proper security practices around password handling. rg --type python $'confirmpassword'
Sanchitbajaj02
added
⭐ enhancement
|
Hi @pahuja-sahil, it will take 1 week for me to review so please bear with it. |
Hi @Sanchitbajaj02 , |
Related Issue
Fixes #338 .
Description
I have upgraded the appwrite from version 13.0.2 to 15.0.0. After doing so made some syntax changes in some files so that the website can work appropriately
Screenshots
Kindly see to these changes and accept my pr if everything is good.
Thank you.
Summary by CodeRabbit
New Features
Improvements