feat: Added a "Scroll to top" button Matching to Website Design Theme #366
Conversation
|
@MastanSayyad is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
title needs formatting
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @MastanSayyad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
WalkthroughThe changes introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ScrollToTopButton
participant Page
User->>Page: Scroll down
User->>ScrollToTopButton: Click ScrollToTop button
ScrollToTopButton->>Page: Scroll to top
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
the
title needs formatting
MastanSayyad
changed the title
github-actions
bot
removed
the
title needs formatting
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/*.lock,!**/*.lock
Files selected for processing (3)
- src/app/layout.tsx (2 hunks)
- src/components/ScrollToTop/scrolltotop.css (1 hunks)
- src/components/ScrollToTop/scrolltotop.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- src/components/ScrollToTop/scrolltotop.css
Additional context used
Biome
src/components/ScrollToTop/scrolltotop.tsx
[error] 24-24: This hook does not specify all of its dependencies: toggleVisibility (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
Either include them or remove the dependency array
[error] 34-34: Provide an explicit type prop for the button element. (lint/a11y/useButtonType)
The default type of a button is submit, which causes the submission of a form when placed inside a
formelement. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
Additional comments not posted (1)
src/app/layout.tsx (1)
6-6: The integration ofScrollToTopcomponent looks good and is correctly placed within the layout.Also applies to: 67-67
Sanchitbajaj02
added
⭐ enhancement
|
Done @Sanchitbajaj02 |
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/ScrollToTop/scrolltotop.tsx (1 hunks)
Additional context used
Biome
src/components/ScrollToTop/scrolltotop.tsx
[error] 23-23: This hook does not specify all of its dependencies: toggleVisibility (lint/correctness/useExhaustiveDependencies)
This dependency is not specified in the hook dependency list.
This dependency is not specified in the hook dependency list.
Either include them or remove the dependency array
[error] 33-36: Provide an explicit type prop for the button element. (lint/a11y/useButtonType)
The default type of a button is submit, which causes the submission of a form when placed inside a
formelement. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
|
Changes Done @Sanchitbajaj02 |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/ScrollToTop/scrolltotop.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/components/ScrollToTop/scrolltotop.tsx
Closes #363
Description
Hey @Sanchitbajaj02 I have added Scroll to top button please take a look and review it, Thank You!!
Screenshots
topbtn.mp4
Summary by CodeRabbit