-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Thankyou email on newsletter subscription #393
feat: Thankyou email on newsletter subscription #393
Conversation
@Ayesha-Siddiqua88 is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Form as Newsletter Form
participant EmailJS as EmailJS Service
participant UI as User Interface
User->>+Form: Fills email and submits form
Form-->>Form: Process submission
Form-->>EmailJS: Send email with subscription details
EmailJS-->>Form: Confirm email sent
Form-->>UI: Show "Subscribed to Newsletter" alert
UI-->>User: Alert notification
EmailJS-->>User: Receive thank you email
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Ayesha-Siddiqua88! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
package.json
is excluded by!**/*.json
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
,!**/*.lock
Files selected for processing (1)
- src/components/core/newsletter/index.tsx (2 hunks)
Additional comments not posted (2)
src/components/core/newsletter/index.tsx (2)
3-3
: Consider cleaning up unused imports.The commented import statement for social media icons (Linkedin, Facebook, Twitter, Instagram) suggests that these are no longer needed. If these are not used elsewhere in your component, consider removing the import to clean up the code.
10-13
: Commented Code: Consider removing or documenting the reason for commenting out.The
handleChange
function is commented out, and its functionality seems to be handled directly in the input'sonChange
event. If this function is no longer needed, consider removing it to avoid confusion. If there's a reason to keep it, please document it clearly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
fixes: #391
Description
Added the feature of sending mails to user when thy subscribe to newsletter using Emailjs.
Screenshots
success console message on clicking 'subscribe' button:
email sent:
Summary by CodeRabbit
emailjs-com
, providing better feedback on submission success or failure.