Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Thankyou email on newsletter subscription #393

Conversation

Ayesha-Siddiqua88
Copy link
Contributor

@Ayesha-Siddiqua88 Ayesha-Siddiqua88 commented Jun 28, 2024

Related Issue

fixes: #391

Description

Added the feature of sending mails to user when thy subscribe to newsletter using Emailjs.

Screenshots

success console message on clicking 'subscribe' button:
gssoc27

email sent:
gssoc28

Summary by CodeRabbit

  • New Features
    • Improved newsletter form functionality: Submitting the form now sends an email using emailjs-com, providing better feedback on submission success or failure.

Copy link

vercel bot commented Jun 28, 2024

@Ayesha-Siddiqua88 is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jun 28, 2024

Walkthrough

The Newsletter component in src/components/core/newsletter/index.tsx has been updated to send an automated thank you email through emailjs-com when a form is submitted. This includes directly updating the subscriberEmail state on input changes and handling success/error responses for the email submission. The handleChange function is now commented out since its functionality has been incorporated directly into the input event handler.

Changes

File/Path Change Summary
src/components/core/newsletter/index.tsx Commented out handleChange function, updated handleSubmit to send email with emailjs-com, included success/error handling.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Form as Newsletter Form
  participant EmailJS as EmailJS Service
  participant UI as User Interface

  User->>+Form: Fills email and submits form
  Form-->>Form: Process submission
  Form-->>EmailJS: Send email with subscription details
  EmailJS-->>Form: Confirm email sent
  Form-->>UI: Show "Subscribed to Newsletter" alert
  UI-->>User: Alert notification
  EmailJS-->>User: Receive thank you email
Loading

Assessment against linked issues

Objective Addressed Explanation
Automated thank you email for newsletter subscription (#391)
Alert with "Subscribed to Newsletter" message on subscribe button click (#391)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Ayesha-Siddiqua88! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!

'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9c076c2 and b7e8ace.

Files ignored due to path filters (2)
  • package.json is excluded by !**/*.json
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock, !**/*.lock
Files selected for processing (1)
  • src/components/core/newsletter/index.tsx (2 hunks)
Additional comments not posted (2)
src/components/core/newsletter/index.tsx (2)

3-3: Consider cleaning up unused imports.

The commented import statement for social media icons (Linkedin, Facebook, Twitter, Instagram) suggests that these are no longer needed. If these are not used elsewhere in your component, consider removing the import to clean up the code.


10-13: Commented Code: Consider removing or documenting the reason for commenting out.

The handleChange function is commented out, and its functionality seems to be handled directly in the input's onChange event. If this function is no longer needed, consider removing it to avoid confusion. If there's a reason to keep it, please document it clearly.

src/components/core/newsletter/index.tsx Show resolved Hide resolved
src/components/core/newsletter/index.tsx Show resolved Hide resolved
Copy link
Owner

@Sanchitbajaj02 Sanchitbajaj02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sanchitbajaj02 Sanchitbajaj02 added 🏆 good first issue Good for newcomers ⭐ enhancement Feature enhancement EASY Difficulty Level: Easy level1 10 points and removed wait for reviewers labels Jul 12, 2024
@Sanchitbajaj02 Sanchitbajaj02 merged commit 383fdb3 into Sanchitbajaj02:master Jul 12, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EASY Difficulty Level: Easy ⭐ enhancement Feature enhancement 🏆 good first issue Good for newcomers gssoc GSSOC'24 Required Label level1 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Automated thank you email for newsletter subscription
2 participants