-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tour popup above cursor #395
fix: tour popup above cursor #395
Conversation
@SuperSahitya is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent changes address a cursor disappearance issue within a tour popup on the platform. The issue was fixed by adding specific z-index values in the CSS file and updating the Tailwind configuration to ensure proper layering of elements. These changes prevent the cursor from being hidden beneath other elements, facilitating smooth interaction with the tour popup. Changes
Sequence Diagram(s)Not applicable due to the simplicity of the changes. Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @SuperSahitya! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/styles/shepherdStyles.css (2 hunks)
- tailwind.config.js (1 hunks)
Files skipped from review due to trivial changes (1)
- tailwind.config.js
Additional context used
Biome
src/styles/shepherdStyles.css
[error] 52-52: expected
;
but instead the file endsthe file ends here
(parse)
Good work @SuperSahitya 👏 |
@Sanchitbajaj02 Should I work on other issues, or do I need to be assigned the issues before creating a PR ? |
you can take up other issues. Due to some personal issues, I am having trouble focusing on the project. I assure you that it gets merged soon. The issue wasn't assigned to you. To get it merged, please comment under the issue, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
closes #376
Description
Fixed the bug that causes the tour popup to appear above cursor
Screenshots
Summary by CodeRabbit
New Features
z-index
value (900) for enhanced layering control.Style
.shepherd-element
withz-custom
property..shepherd-modal-overlay-container
class withz-50
.