Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tour popup above cursor #395

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

SuperSahitya
Copy link
Contributor

@SuperSahitya SuperSahitya commented Jul 7, 2024

Related Issue

closes #376

Description

Fixed the bug that causes the tour popup to appear above cursor

Screenshots

image

Summary by CodeRabbit

  • New Features

    • Introduced a custom z-index value (900) for enhanced layering control.
  • Style

    • Updated .shepherd-element with z-custom property.
    • Added .shepherd-modal-overlay-container class with z-50.

Copy link

vercel bot commented Jul 7, 2024

@SuperSahitya is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 7, 2024

Walkthrough

The recent changes address a cursor disappearance issue within a tour popup on the platform. The issue was fixed by adding specific z-index values in the CSS file and updating the Tailwind configuration to ensure proper layering of elements. These changes prevent the cursor from being hidden beneath other elements, facilitating smooth interaction with the tour popup.

Changes

File Change Summary
src/styles/shepherdStyles.css Added z-custom to .shepherd-element and new .shepherd-modal-overlay-container class with z-50.
tailwind.config.js Introduced a custom z-index value of 900 under the theme section.

Sequence Diagram(s)

Not applicable due to the simplicity of the changes.

Assessment against linked issues

Objective Addressed Explanation
Bug: Cursor Disappears Inside Tour Popup (#376)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SuperSahitya! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!

'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9c076c2 and 4dde484.

Files selected for processing (2)
  • src/styles/shepherdStyles.css (2 hunks)
  • tailwind.config.js (1 hunks)
Files skipped from review due to trivial changes (1)
  • tailwind.config.js
Additional context used
Biome
src/styles/shepherdStyles.css

[error] 52-52: expected ; but instead the file ends

the file ends here

(parse)

src/styles/shepherdStyles.css Show resolved Hide resolved
src/styles/shepherdStyles.css Show resolved Hide resolved
@Amitooo1
Copy link
Contributor

Amitooo1 commented Jul 8, 2024

Good work @SuperSahitya 👏

@SuperSahitya
Copy link
Contributor Author

@Sanchitbajaj02 Should I work on other issues, or do I need to be assigned the issues before creating a PR ?

@Sanchitbajaj02
Copy link
Owner

Sanchitbajaj02 commented Jul 12, 2024

@Sanchitbajaj02 Should I work on other issues, or do I need to be assigned the issues before creating a PR ?

you can take up other issues. Due to some personal issues, I am having trouble focusing on the project. I assure you that it gets merged soon.

The issue wasn't assigned to you. To get it merged, please comment under the issue, thanks

Copy link
Owner

@Sanchitbajaj02 Sanchitbajaj02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sanchitbajaj02 Sanchitbajaj02 added 🪲 bug Something isn't working 🛠 goal: fix The label is related to fixing a bug EASY Difficulty Level: Easy level1 10 points SSOC SSOC'24 Required Label and removed wait for reviewers labels Jul 12, 2024
@Sanchitbajaj02 Sanchitbajaj02 merged commit 7b62896 into Sanchitbajaj02:master Jul 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working EASY Difficulty Level: Easy 🛠 goal: fix The label is related to fixing a bug gssoc GSSOC'24 Required Label level1 10 points SSOC SSOC'24 Required Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cursor Disappears Inside Tour Popup
3 participants