Repository navigation
Conversation
When MAGI_COMPILE_AOT=1, models using SimpleFSDP/DTensor may fail AOT compilation (e.g. "Attempted to read undefined local variable"). Instead of crashing, catch the exception and fall back to the JIT bytecode capture path. This allows AOT to be enabled globally while FSDP models auto-degrade to JIT + inductor cache hits.
6 tasks done
Collaborator
Author
|
Superseded by #89 (rebased the still-useful parts onto current main). Closing this PR. |
jiahy0825
pushed a commit
that referenced
this pull request
Oct 15, 2026
…split graphs (#89) * fix: cache key on graph+placements, AOT JIT fallback, skip FSDP overlap on split graphs Unmerged remnants of #88 / #86 / #84 / #79, rebased onto current main: - Cache key includes graph.code and DTensor placements. Changing SimpleFSDP fully_shard -> replicate used to reuse the old artifact (1-rank AllGathers served as DtoD copies). - AOT compile failures fall back to JIT so MAGI_COMPILE_AOT=1 can stay process-wide (VAE AOT, SimpleFSDP DiT JIT). - enable_fsdp no longer runs fullgraph overlap when disable_graph_split is False (VAE in a monolithic FSDP process). #79's restart-analysis half already landed as #75. - Timing bench dim 128->1024 so launch jitter does not flake max/min < 1.2 on B300/H100. * fix(cache): hash input placements only, not graph.code Restart-analysis retraces with different FX node names, so including graph.code in the magi cache key made the second pass miss the first-pass directory (test_assert_cache_hit_succeeds_with_restart_analysis / test_restart_analysis_cache on pt212). DTensor fully_shard vs replicate is still distinguished by the input placement signature. * fix(cache): hash only DTensor placements so restart-analysis still hits * fix(aot): do not swallow AssertionError/OOM when AOT falls back to JIT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
MAGI_COMPILE_AOT=1is set globally, models using SimpleFSDP/DTensor fail AOT compilation with:This crashes the entire warmup process, preventing AOT from being used even for compatible models (e.g., VAE which has no FSDP).
Solution
Catch exceptions in the AOT compile path and gracefully fall back to the JIT bytecode capture path. This allows
MAGI_COMPILE_AOT=1to be set globally:Key implementation details:
state.aot_compile()compile_config.aot = Falseto prevent further AOT attempts for this statecompiled_entryand calltorch._dynamo.reset()to clear AOT-onlyguard_filter_fn_ensure_compiled()for JIT mode and proceed with bytecode captureContext
Part of CI cold-start optimization effort (athena PR #1112). AOT serializes Dynamo FX graphs so verify can skip Dynamo tracing + RestartAnalysis entirely (~42s savings for compatible models).