-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement OnyxAccordion
component
#2401
Open
ChristianBusshoff
wants to merge
29
commits into
main
Choose a base branch
from
feat/2140-implement-onyxAccordion-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: implement OnyxAccordion
component
#2401
ChristianBusshoff
wants to merge
29
commits into
main
from
feat/2140-implement-onyxAccordion-component
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ChristianBusshoff
commented
Dec 23, 2024
- implement OnyxAccordion & AccordionItem
🦋 Changeset detectedLatest commit: a689be3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
larsrickert
changed the title
Feat/2140 implement onyx accordion component
feat: implement Jan 2, 2025
OnyxAccordion
component
larsrickert
requested changes
Jan 2, 2025
packages/sit-onyx/src/components/OnyxAccordion/OnyxAccordion.stories.ts
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordion/OnyxAccordion.stories.ts
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordion/OnyxAccordion.stories.ts
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Show resolved
Hide resolved
ChristianBusshoff
force-pushed
the
feat/2140-implement-onyxAccordion-component
branch
from
January 3, 2025 08:29
fbe4a6a
to
ca698a8
Compare
larsrickert
requested changes
Jan 7, 2025
packages/sit-onyx/src/components/OnyxAccordion/OnyxAccordion.ct.tsx
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordion/OnyxAccordion.ct.tsx
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordion/OnyxAccordion.ct.tsx
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
larsrickert
requested changes
Jan 8, 2025
packages/sit-onyx/src/components/OnyxAccordion/OnyxAccordion.stories.ts
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.ct.tsx
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordion/OnyxAccordion.ct.tsx
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: ChristianBusshoff <[email protected]>
larsrickert
requested changes
Jan 14, 2025
.../sit-onyx/playwright/snapshots/components/OnyxAccordion/Accordion-disabled--webkit-linux.png
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.ct.tsx
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxAccordionItem/OnyxAccordionItem.vue
Outdated
Show resolved
Hide resolved
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: ChristianBusshoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.