Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata configuration files #28

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Conversation

nitrosx
Copy link
Contributor

@nitrosx nitrosx commented May 31, 2024

This PR adds the first instrument metadata configuration file example.
The format of the file is still in draft mode. Most likely it will require more discussion before is finalized.

@nitrosx nitrosx requested a review from YooSunYoung May 31, 2024 13:29
@nitrosx nitrosx added this to the Refactoring milestone May 31, 2024
@nitrosx nitrosx added the enhancement New feature or request label May 31, 2024
@YooSunYoung YooSunYoung changed the base branch from main to wrdn_message June 11, 2024 00:49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file something you would edit/modify while the ingester is running?
If not, maybe it'll be easier if we turn it into a python module instead of json file.

@YooSunYoung YooSunYoung changed the base branch from wrdn_message to main June 11, 2024 09:11
@YooSunYoung YooSunYoung merged commit 399dbfa into main Jun 11, 2024
3 checks passed
@YooSunYoung YooSunYoung deleted the metadata_configuration_files branch June 11, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants