All the fixes introduced while testing the production deployments #93
Conversation
| output_value = ( | ||
| output_value if isinstance(var_value, str) else json.loads(output_value) | ||
| ) |
There was a problem hiding this comment.
I'm not sure about the intention here. Can you elaborate more? @nitrosx
There was a problem hiding this comment.
In some cases, the variable value (aka var_value) is a list or a dict.
When that is the case, the variable value is converted to a json string, the substitution is executed and converted back to the original type.
Basically it is a trick to perform nested substitutions without traversing the whole nested structure.
Check also line 149.
There was a problem hiding this comment.
Ah it's making the string dumped output_value back to a dictionary/list. I see...
It sounds like a bit of hack but it won't be a problem since > and < are not easy to be mistaken with other symbols used in list or dictionary but we'd better document it.
I'll do it in another PR with some unit tests.
YooSunYoung
force-pushed
the
fixes-for-deployment
branch
from
b6bd79e to
9f37a65
Compare
This PR includes all the changes introduced while testing the manual deployment in production