Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: require explicit independent variable for ODESystem #2443

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@oscardssmith
Copy link
Contributor

What does this fix? This seems like a really breaking change without a ton of benefit.

@ChrisRackauckas
Copy link
Member

It fixes a lot since the equation parsing had a few edge cases where it's not generally fixable without requiring that the independent variable is known.

@ChrisRackauckas
Copy link
Member

If you dig through the closed issues you'll find many cases where ODESystem did it's decomposition incorrectly and that led to an error, with the fix being to use the "right" constructor, i.e. pass in the independent variable too. Some of those cases simply have too little information to solve so the heuristic for determining what is the independent variable is just not generally solvable. Given it's not generally solvable, the best thing to do is to just ask users for it. It's easy and it fixes all of those potential issues.

@ChrisRackauckas ChrisRackauckas merged commit 9fb2316 into SciML:master Feb 2, 2024
9 of 22 checks passed
@ChrisRackauckas
Copy link
Member

Does @mtkbuild need a change?

@AayushSabharwal AayushSabharwal deleted the as/manual-indepvar branch February 2, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants