Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten for complex #2935

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Flatten for complex #2935

merged 3 commits into from
Aug 8, 2024

Conversation

contradict
Copy link
Contributor

Checklist

  • [ x ] Appropriate tests were added
  • [ x ] Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • [ x ] The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes #2895

@contradict
Add test for complex equations
deb0b90
@contradict
Flatten equations to handle complex equations.
17311e7 
Complex equations are expanded into a real and imagianry part meaning
one equations entered by the user can be parsed into a Vector of two
equations. This patch accumulates equations and pairs of equations
during parsing and then flattens the whole list at the end.

Fixes SciML#2895
@contradict
Run formatter
9eb7e8c
@ChrisRackauckas ChrisRackauckas merged commit 47aa59d into SciML:master Aug 8, 2024
23 checks passed
@hexaeder hexaeder mentioned this pull request Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use Complex equation in @mtkmodel
2 participants
@contradict @ChrisRackauckas