Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support JumpProblems over ODEProblems #2946

Merged
merged 7 commits into from
Aug 11, 2024

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Aug 9, 2024

To enable more automatic VariableRateJump handling.

@AayushSabharwal this is supposed to allow JumpProblems over ODEProblems, but symbolic indexing of solutions and plotting / plot legends are not working. I just copied how we did JumpProblems over DiscreteProblems, but that doesn't seem to work? Can you let me know how to update the dummy ODEProblem(::JumpSystem,...) here to get it working? Thanks!

TODO:

  • Fix dependency graph generation to ignore VariableRateJumps and add tests.
  • Get symbolic indexing working for the resulting solutions

Basic plot(sol) is currently broken but that is more of a SciMLBase / JumpProcesses issue from the ExtendedJumpArrays. Plotting works with explicit specification of indexes to plot.

Edit: Needs JumpProcesses 438 and a JumpProcesses release.

@isaacsas
Copy link
Member Author

isaacsas commented Aug 9, 2024

Also, just to add I tried alternatively creating an ODEProblem via an ODESystem with the unknowns, parameters, defaults, and observed from the JumpSystem (but no equations), however, that also did not result in solutions that could be symbolically indexed or plots that had proper symbolic naming/indexing.

@isaacsas
Copy link
Member Author

isaacsas commented Aug 9, 2024

@ChrisRackauckas @AayushSabharwal so this won't work cleanly until symbolic indexing / plotting for solutions that are represented as ExtendedJumpArrays is supported. I don't know what getting such support to work would entail, but it would be nice to have (and should I guess also be added for JumpProblems over SDEProblems where one gets ExtendedJumpArrays for u).

@isaacsas isaacsas closed this Aug 10, 2024
@isaacsas isaacsas reopened this Aug 10, 2024
@ChrisRackauckas
Copy link
Member

What's the current state here?

@isaacsas isaacsas changed the title [WIP] support JumpProblems over ODEProblems support JumpProblems over ODEProblems Aug 11, 2024
@isaacsas
Copy link
Member Author

@ChrisRackauckas This is good I think.

@ChrisRackauckas
Copy link
Member

okay cool, that's what I thought.

@ChrisRackauckas ChrisRackauckas merged commit e4e7d97 into SciML:master Aug 11, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants