-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support JumpProblems over ODEProblems #2946
Conversation
Also, just to add I tried alternatively creating an ODEProblem via an ODESystem with the unknowns, parameters, defaults, and observed from the JumpSystem (but no equations), however, that also did not result in solutions that could be symbolically indexed or plots that had proper symbolic naming/indexing. |
@ChrisRackauckas @AayushSabharwal so this won't work cleanly until symbolic indexing / plotting for solutions that are represented as ExtendedJumpArrays is supported. I don't know what getting such support to work would entail, but it would be nice to have (and should I guess also be added for JumpProblems over SDEProblems where one gets ExtendedJumpArrays for |
What's the current state here? |
@ChrisRackauckas This is good I think. |
okay cool, that's what I thought. |
To enable more automatic VariableRateJump handling.
@AayushSabharwal this is supposed to allow JumpProblems over ODEProblems, but symbolic indexing of solutions and plotting / plot legends are not working. I just copied how we did JumpProblems over DiscreteProblems, but that doesn't seem to work? Can you let me know how to update the dummy ODEProblem(::JumpSystem,...) here to get it working? Thanks!TODO:
Fix dependency graph generation to ignoreVariableRateJump
s and add tests.Get symbolic indexing working for the resulting solutionsBasic
plot(sol)
is currently broken but that is more of a SciMLBase / JumpProcesses issue from the ExtendedJumpArrays. Plotting works with explicit specification of indexes to plot.Edit: Needs JumpProcesses 438 and a JumpProcesses release.