Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow read while reencryption #1667

Merged
merged 16 commits into from
Apr 9, 2021
Merged

Allow read while reencryption #1667

merged 16 commits into from
Apr 9, 2021

Conversation

vxgmichel
Copy link
Contributor

@vxgmichel vxgmichel commented Mar 22, 2021 •
edited
Loading

Fix #1650.

Still a WIP, missing:

  • tests
  • postresql backend implementation

@vxgmichel vxgmichel requested a review from touilleMan March 22, 2021 17:41
@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #1667 (a0231bb) into master (4bbaec8) will decrease coverage by 0.07%.
The diff coverage is 95.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
- Coverage   87.71%   87.64%   -0.08%     
==========================================
  Files         243      243              
  Lines       23421    23488      +67     
==========================================
+ Hits        20544    20586      +42     
- Misses       2877     2902      +25
Impacted Files Coverage Δ
parsec/api/protocol/handshake.py 96.13% <ø> (ø)
parsec/backend/memory/message.py 100.00% <ø> (ø)
parsec/backend/memory/organization.py 96.87% <ø> (ø)
parsec/backend/memory/user.py 96.44% <ø> (ø)
parsec/backend/postgresql/organization.py 91.04% <ø> (ø)
parsec/backend/postgresql/user.py 93.75% <ø> (ø)
parsec/backend/memory/block.py 89.23% <78.57%> (-3.76%) ⬇️
parsec/backend/blockstore.py 69.04% <88.88%> (ø)
parsec/backend/memory/vlob.py 95.55% <89.47%> (-0.94%) ⬇️
parsec/backend/client_context.py 94.87% <90.00%> (+0.27%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bbaec8...a0231bb. Read the comment docs.

touilleMan
touilleMan reviewed Mar 24, 2021
View reviewed changes
parsec/backend/memory/vlob.py Outdated Show resolved Hide resolved
parsec/core/fs/remote_loader.py Outdated Show resolved Hide resolved
parsec/core/fs/userfs/userfs.py Outdated Show resolved Hide resolved
parsec/core/fs/remote_loader.py Show resolved Hide resolved
parsec/core/fs/remote_loader.py Show resolved Hide resolved
parsec/core/fs/userfs/userfs.py Show resolved Hide resolved
parsec/core/fs/remote_loader.py Outdated Show resolved Hide resolved
vxgmichel added a commit that referenced this pull request Mar 25, 2021
@vxgmichel
Improve compatibility with backends that don't include PR #1667
b7489f3
@vxgmichel vxgmichel force-pushed the allow-read-while-reencryption branch 2 times, most recently from 688b3c7 to d3b0c8b Compare March 31, 2021 00:39
touilleMan
touilleMan requested changes Apr 2, 2021
View reviewed changes
tests/core/mountpoint/test_file_failures.py Outdated Show resolved Hide resolved
tests/core/fs/test_reencrypt_workspace.py Show resolved Hide resolved
tests/core/fs/test_reencrypt_workspace.py Show resolved Hide resolved
tests/backend/realm/test_block.py Outdated Show resolved Hide resolved
parsec/core/fs/userfs/userfs.py Outdated Show resolved Hide resolved
parsec/backend/memory/block.py Outdated Show resolved Hide resolved
parsec/backend/realm.py Show resolved Hide resolved
parsec/backend/memory/vlob.py Outdated Show resolved Hide resolved
parsec/core/fs/remote_loader.py Show resolved Hide resolved
@vxgmichel vxgmichel force-pushed the allow-read-while-reencryption branch from 14fdc5e to 104f96c Compare April 6, 2021 23:21
@vxgmichel vxgmichel requested a review from touilleMan April 7, 2021 08:26
touilleMan
touilleMan requested changes Apr 8, 2021
View reviewed changes
mypy.ini Outdated Show resolved Hide resolved
parsec/backend/client_context.py Show resolved Hide resolved
parsec/backend/client_context.py Outdated Show resolved Hide resolved
parsec/backend/client_context.py Outdated Show resolved Hide resolved
parsec/backend/client_context.py Outdated Show resolved Hide resolved
parsec/backend/memory/realm.py Show resolved Hide resolved
parsec/backend/memory/vlob.py Outdated Show resolved Hide resolved
parsec/backend/postgresql/realm_queries/get.py Outdated Show resolved Hide resolved
parsec/backend/postgresql/user_queries/get.py Outdated Show resolved Hide resolved
parsec/core/fs/userfs/userfs.py Outdated Show resolved Hide resolved
@vxgmichel vxgmichel force-pushed the allow-read-while-reencryption branch from c81a5ff to 9ddb38c Compare April 8, 2021 15:30
@vxgmichel vxgmichel force-pushed the allow-read-while-reencryption branch from 11d796e to 6a4b2df Compare April 8, 2021 16:30
@vxgmichel vxgmichel requested a review from touilleMan April 9, 2021 09:49
touilleMan
touilleMan approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@vxgmichel vxgmichel merged commit fc50405 into master Apr 9, 2021
@vxgmichel vxgmichel deleted the allow-read-while-reencryption branch April 9, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@touilleMan touilleMan touilleMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow read access during Workspace reencryption
2 participants
@vxgmichel @touilleMan