Repository navigation
test(session-runtime): keep fake summarizer under default budget - #4521
Merged
ScriptedAlchemy merged 2 commits intoOct 25, 2026
Conversation
|
The fake cursor-agent in the LCM effects tests ran under a 5 s provider timeout, the smallest admitted value. On a loaded runner the /bin/sh child is starved past 5 s, the provider kills it, and the session is parked as cursor_agent_unavailable until the summarizer binding changes. The test then waits out its 30 s poll for summaries that can never publish. Use the provider default budget so the stand-in is not killed by scheduling delay. The polling waits are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ScriptedAlchemy
force-pushed
the
fix/lcm-summary-frontier-test-flake
branch
from
October 24, 2026 23:23
671af53 to
1a151ef
Compare
This was referenced Oct 25, 2026
ScriptedAlchemy
changed the base branch from
master
to
renovate/modelcontextprotocol-client-2.x-lockfile
October 25, 2026 01:30
ScriptedAlchemy
merged commit Oct 25, 2026
d6cd868
into
renovate/modelcontextprotocol-client-2.x-lockfile
6 checks passed
This was referenced Oct 25, 2026
neoneye
pushed a commit
to agent-memory-atlas-archive/ScriptedAlchemy--tracedecay
that referenced
this pull request
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack order (merge first → last): #4473 → #4478 → #4521 → #4526 → #4515 → #4510 → #4516 → #4524 → #4489 → #4488 → #4485
This PR is layer 3/11, based on #4478. Next: #4526.
Merge bottom to top using merge commits. After each parent merges, retarget its child to master before merging the child; this preserves the ancestry already integrated and avoids reintroducing conflicts.
Fixes #4518
Problem.
lcm_effects::tests::refresh_begins_at_the_committed_frontier_after_background_summaries_publishfails intermittently on loaded runners withtimed out waiting for background summaries to publish.Root cause. Not a production ordering bug. The test pinned its fake
cursor-agentscript withtimeout_secs = 5, the smallest admitted value. Under load the/bin/shchild is starved for more than 5 s, the provider kills it, and the convergence queue parks the session asunavailable/cursor_agent_unavailable. That state is only requeued when the summarizer binding changes, so the 30 s poll can never see a summary node. I confirmed this by dumping the queue row and the provider error on timeout (timed out waiting for .../cursor-agent) in every failing run.Fix. The test no longer sets the 5 s provider budget, so the provider default applies and scheduling delay cannot kill the stand-in. The same pin in
parked_sessions_converge_once_the_summarizer_becomes_available_without_restarthad the same exposure and gets the same change. No poll timeout was raised and no assertion changed.Verification. Test binary run directly, 150 concurrent copies at a time on an 18-core machine,
--exactwith the full path (1 passed confirmed):At 300 concurrent copies each run takes 80 to 100 s and any timed wait fails, with or without this change, so that load is not meaningful.
bazel test //crates/tracedecay-session-runtime:unit_testpasses andbazel build --config=clippy //crates/tracedecay-session-runtime/...is clean.🤖 Generated with Claude Code