Skip to content

fix: restore #4527, #4528 and #4530 dropped from the release branch - #4587

Merged
ScriptedAlchemy merged 4 commits into
masterfrom
fix/restore-dropped-stack-commits
Oct 28, 2026
Merged

ScriptedAlchemy merged 4 commits into
masterfrom
fix/restore-dropped-stack-commits

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Problem

#4527, #4528 and #4530 show as merged, but their changes never reached master. They were part of a stack based on release-please's branch, so GitHub merged them into release-please--branches--master--components--tracedecay. Release-please later regenerated that branch, and the merge commits (d2abbd2, f88d52f, 1141108) are gone. Sampling each PR's added lines finds almost none on master.

Fix

Cherry-picks only each PR's own commit onto master, in stack order, leaving out the release version-bump commits that came in through the release-branch merge:

The only conflict was the test import list in tracedecay-configuration/src/config/mod.rs, resolved by taking the union of both sides. The remaining stack (#4531 → #4529 → #4534 → #4541) will be rebuilt on top of this.

Verification

  • cargo +1.99.0 clippy -D warnings on privacy, domain, configuration, global-db and search-eval (lib and tests): clean
  • Changed Rust sources are rustfmt-clean; the reported files are eval fixtures, which the gate excludes
  • Generated BUILD files are left to CI's Repository gates --check

🤖 Generated with Claude Code


Devin Review

Restack unique #4527 onto the rewritten #4485 tip.

(cherry picked from commit 6b5a992)
Restack unique #4528 onto the rewritten #4527 tip.

(cherry picked from commit fbb57b0)
Restack unique #4530 onto the rewritten #4528 tip.

(cherry picked from commit f419918)
@ScriptedAlchemy
ScriptedAlchemy enabled auto-merge (squash) October 27, 2026 21:08
@changeset-bot

changeset-bot Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a68d247

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

The restored package-boundary helper defaulted to the old module-level
REPO, which #4543 replaced with the runfiles-resolved workspace.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

Included in the integration PR #4589, which runs CI once for all open PRs. This PR will be marked merged automatically when #4589 lands.

@ScriptedAlchemy
ScriptedAlchemy merged commit 8f961b3 into master Oct 28, 2026
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant