Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

CI tweaks #366

Merged
merged 3 commits into from
Jan 30, 2024
Merged

CI tweaks #366

merged 3 commits into from
Jan 30, 2024

Conversation

ariostas
Copy link
Member

I made the following tweaks to the CI.

Here are the changes in this PR:

  • Removed the cmssw branch validation code. There was a bug where if there was a new line after the name it would think that it was invalid. This was because new lines in GitHub are \r\n, so the branch name ended up being set to "some_branch\r". The branch validation code is now delegated to the action.
  • Updated a few actions that were outdated, and moved to using the version of the TrackLooper-actions actions in the main branch instead of a specific tag since we're the only ones using them so there's no point in keeping tags.
  • Added dependabot.yml so that GitHub keeps the actions in the CI up to date.

Here are the changes on the TrackLooper-actions side:

  • Fixed the branch validation code to strip command characters.
  • When an integer number is given as the branch name it is now interpreted as a PR number.
  • GitHub is bumped runners on public repos to 4 cores, so I updated the script to use the extra cores. It should mainly be noticeable in the standalone testing. (For the cmssw testing there are other bottlenecks that I haven't figured out how to overcome.)

@slava77
Copy link
Contributor

slava77 commented Jan 26, 2024

Here are the changes on the TrackLooper-actions side:

you may want to consider making PRs in TrackLooper-actions so that updates are more clearly visible (the self-merge is OK)

@slava77 slava77 merged commit 30a79ad into master Jan 30, 2024
1 check passed
@ariostas ariostas deleted the ci-tweaks branch January 30, 2024 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants