feat: new trace details waterfall integration #6708
Draft
+1,426
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
contributes to - #6132 |
vikrantgupta25
changed the title
nityanandagohain
requested changes
Jan 9, 2025
| @@ -156,6 +158,8 @@ type ClickHouseReader struct { | |||
| traceLocalTableName string | |||
| traceResourceTableV3 string | |||
| traceSummaryTable string | |||
|
|
|||
| CacheV2 cacheV2.Cache | |||
There was a problem hiding this comment.
can be private instead of public ? cacheV2
| @@ -1441,6 +1449,293 @@ func (r *ClickHouseReader) SearchTraces(ctx context.Context, params *model.Searc | |||
| return &searchSpansResult, nil | |||
| } | |||
|
|
|||
| func contains(slice []string, item string) bool { | |||
|
|
||
| // create the trace tree based on the spans fetched above | ||
| // create a map of [spanId]: spanNode | ||
| for _, item := range searchScanResponses { |
There was a problem hiding this comment.
this logic can be moved to utils/traces. And proper test cases
|
|
||
| // traverse through the map and append each node to the children array of the parent node | ||
| // capture the root nodes as well | ||
| for _, spanNode := range spanIdToSpanNodeMap { |
|
|
||
| // mark the current path from root to the interested node as uncollapsed | ||
| // Important - do not mark the interested node as uncollapsed in the above exercise to handle node collapses | ||
| rootToInterestedNodePath = func(node *model.Span) bool { |
There was a problem hiding this comment.
this part as well, should be invdividually testable
| // get the index for the interested span id | ||
| if req.InterestedSpanID != "" { | ||
| for i, span := range preOrderTraversal { | ||
| if span.SpanID == req.InterestedSpanID { |
There was a problem hiding this comment.
can this logic be merged with traverse function, this will prevent reiteration ?
| @@ -538,6 +538,7 @@ func (aH *APIHandler) RegisterRoutes(router *mux.Router, am *AuthMiddleware) { | |||
|
|
|||
| router.HandleFunc("/api/v2/traces/fields", am.ViewAccess(aH.traceFields)).Methods(http.MethodGet) | |||
| router.HandleFunc("/api/v2/traces/fields", am.EditAccess(aH.updateTraceField)).Methods(http.MethodPost) | |||
| router.HandleFunc("/api/v2/traces/{traceId}", am.ViewAccess(aH.SearchTracesV3)).Methods(http.MethodPost) | |||
There was a problem hiding this comment.
rename searchTracesV3 to listSpans or getSpansForTrace ?
| Level int64 `json:"level"` | ||
| } | ||
|
|
||
| type SearchTracesV3Cache struct { |
There was a problem hiding this comment.
this shouldn't be in response.go as it is not a response struct.
| @@ -315,6 +315,12 @@ type SearchTracesParams struct { | |||
| MaxSpansInTrace int `json:"maxSpansInTrace"` | |||
| } | |||
|
|
|||
| type SearchTracesV3Params struct { | |||
| InterestedSpanID string `json:"interestedSpanId"` | |||
There was a problem hiding this comment.
nit: instead of insterested, will selectedSpanID be more verbose ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
v2/traces/{traceID}for the new trace details APIinterestedSpanIdreceived from frontendRelated Issues / PR's
contributes to - #6132
Screenshots
NA
Affected Areas and Manually Tested Areas