feat: aws integration: UI facing QS api for cloud account management

[raj-k-singh]

Summary

Adds Query Service APIs for powering AWS integrations UI

Related Issues / PR's

Contributes to #6544

---

Important

Add AWS cloud account management API to Query Service with new routes, controllers, models, and tests.

• API and Routes:
  • Added RegisterCloudIntegrationsRoutes in http_handler.go to handle AWS cloud account management.
  • New routes for generating connection URLs, listing accounts, checking account status, updating config, disconnecting accounts, and agent check-ins.
• Controllers and Models:
  • Introduced cloudintegrations.Controller in controller.go for managing cloud accounts.
  • Added models Account, AccountRecord, AccountConfig, and AgentReport in model.go.
  • Implemented repository pattern in repo.go for database interactions.
• Server and Initialization:
  • Integrated CloudIntegrationsController in server.go and api.go.
  • Initialized cloud integrations in NewServer and NewAPIHandler.
• Testing:
  • Added integration tests in signoz_cloud_integrations_test.go to validate AWS integration lifecycle.
  • Utilized NewCloudIntegrationsTestBed for setting up test environment.
• Miscellaneous:
  • Added Readme.md in cloudintegrations to describe the purpose and limitations of cloud integrations.

^{This description was created by for 2ff511e. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 5e1246b in 1 minute and 53 seconds

More details

• Looked at 1390 lines of code in 11 files
• Skipped 0 files when reviewing.
• Skipped posting 6 drafted comments based on config settings.

1. pkg/query-service/utils/testutils.go:19

• Draft comment:
  Consider checking the error returned by os.Remove in the cleanup function to ensure the temporary file is successfully deleted. This will help avoid leftover files in the system.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function NewTestSqliteDB creates a temporary SQLite database for testing purposes. However, it does not handle the case where the temporary file cannot be removed during cleanup. This could lead to leftover files in the system.

2. pkg/query-service/utils/testutils.go:33

• Draft comment:
  The TODO comment suggests that passing the DB file path should not be necessary. Consider refactoring the code to eliminate the need for passing the DB file path to dao.InitDao and dashboards.InitDB.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The NewQueryServiceDBForTests function initializes the DAO and dashboards with the test database file path. However, the TODO comment suggests that passing the DB file path should not be necessary. This indicates a potential area for improvement in the codebase.

3. pkg/query-service/app/cloudintegrations/controller.go:1

• Draft comment:
  Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well.
• Reason this comment was not posted:
  Comment was on unchanged code.

4. pkg/query-service/app/cloudintegrations/repo.go:1

• Draft comment:
  Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well.
• Reason this comment was not posted:
  Marked as duplicate.

5. pkg/query-service/app/cloudintegrations/model.go:1

• Draft comment:
  Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well.
• Reason this comment was not posted:
  Marked as duplicate.

6. pkg/query-service/app/cloudintegrations/controller_test.go:1

• Draft comment:
  Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_wjestgZYRSegDlj2

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 26bd4e3 in 34 seconds

More details

• Looked at 56 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. pkg/query-service/app/cloudintegrations/controller.go:227

• Draft comment:
  The error message 'couldn't disconnect account' is appropriate here as it aligns with the operation being performed.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The error message in the DisconnectAccount function should be consistent with the operation being performed. The current message 'couldn't disconnect account' is appropriate for the context of the operation.

2. pkg/query-service/app/cloudintegrations/controller.go:235

• Draft comment:
  The error message 'couldn't disconnect account' is appropriate here as it aligns with the operation being performed.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The error message in the DisconnectAccount function should be consistent with the operation being performed. The current message 'couldn't disconnect account' is appropriate for the context of the operation.

3. pkg/query-service/app/cloudintegrations/controller_test.go:99

• Draft comment:
  The test correctly checks for an error when disconnecting a non-existent account. The assertions are appropriate.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The test function TestCantDisconnectNonExistentAccount is correctly checking for the error when trying to disconnect a non-existent account. The assertions are appropriate and ensure the function behaves as expected.

4. pkg/query-service/app/cloudintegrations/controller.go:222

• Draft comment:
  Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This is also applicable in other parts of the code where inline styles are used.
• Reason this comment was not posted:
  Comment was not on a valid diff hunk.

Workflow ID: wflow_DkNLsRrpyLyU4I9I

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 2ff511e in 1 minute and 26 seconds

More details

• Looked at 59 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. pkg/query-service/app/cloudintegrations/controller_test.go:125

• Draft comment:
  The test case TestAgentCheckIns was updated to expect apiErr to be nil after a successful check-in, which aligns with the changes in the CheckInAsAgent function. This is a correct change.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The test case TestAgentCheckIns was modified to expect apiErr to be nil after a successful check-in, which aligns with the changes in the CheckInAsAgent function. This is a correct change, but it should be noted for clarity.

Workflow ID: wflow_gtGjfF3MjgAtKKTF

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[srikanthccv]

@raj-k-singh please check the ee references in MIT licensed code error