-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Modifies messaging queue paylod #6783
fix: Modifies messaging queue paylod #6783
Conversation
Signed-off-by: Shivanshu Raj Shrivastava <[email protected]>
Signed-off-by: Shivanshu Raj Shrivastava <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to ece8518 in 1 minute and 44 seconds
More details
- Looked at
985
lines of code in8
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. pkg/query-service/app/integrations/messagingQueues/celery/translator.go:1
- Draft comment:
Thetranslator.go
file in thecelery
package is currently empty. If this is intentional for future implementation, consider adding a comment to indicate that. Otherwise, ensure that any necessary code is added. - Reason this comment was not posted:
Confidence changes required:20%
The filetranslator.go
in thecelery
package is currently empty. This might be intentional if the implementation is planned for later, but it's worth noting in case it was accidentally left empty.
2. pkg/query-service/app/integrations/messagingQueues/queues/model.go:29
- Draft comment:
TheQueueFilters
struct is defined here and also inkafka/model.go
. Consider consolidating these definitions to avoid duplication and potential maintenance issues. - Reason this comment was not posted:
Confidence changes required:50%
TheQueueFilters
struct is defined in bothkafka/model.go
andqueues/model.go
. This duplication can lead to maintenance issues. Consider consolidating these definitions if they serve the same purpose.
3. pkg/query-service/app/integrations/messagingQueues/queues/sql.go:10
- Draft comment:
ThegenerateOverviewSQL
function is similar to a removed function inkafka/sql.go
. Ensure that this new implementation covers all necessary cases and that the removal was intentional. - Reason this comment was not posted:
Confidence changes required:40%
ThegenerateOverviewSQL
function inqueues/sql.go
is similar to a removed function inkafka/sql.go
. Ensure that the new implementation covers all necessary cases and that the removal was intentional.
4. pkg/query-service/app/integrations/messagingQueues/celery/translator.go:1
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in this file and other similar files in the PR. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_GTlAVbW0dtiCyJpc
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Shivanshu Raj Shrivastava <[email protected]>
As per discussion with @srikanthccv we want to have a unified json paylod across all new APIs, the earlier APIs were designed to have less payload and minimal configuration from frontend, but as per the discussion, it makes the APIs future proof to add enhancements in the product. Hence doing some rework to support filters, #6757, and #6767 will be also be updated following similar logic. The other new APIs would also use the similar payload. |
pkg/query-service/app/integrations/messagingQueues/queues/sql.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivanshu Raj Shrivastava <[email protected]>
Signed-off-by: Shivanshu Raj Shrivastava <[email protected]>
related to https://github.com/SigNoz/engineering-pod/issues/2009
fixes: #6768
Important
This PR refines messaging queue payload handling by introducing Kafka-specific parsing and query logic, and sets up a framework for Celery integration.
ParseMessagingQueueBody
withParseKafkaQueueBody
inhttp_handler.go
for Kafka-specific parsing.ParseQueueBody
for generic queue parsing inhttp_handler.go
.onboardProducers
,onboardConsumers
, andonboardKafka
functions inhttp_handler.go
to use Kafka-specific logic.BuildOverviewQuery
inqueues/queueOverview.go
for building overview queries.generateOverviewSQL
fromkafka/sql.go
toqueues/sql.go
.BuildClickHouseQuery
andBuildQueryRangeParams
inkafka/translator.go
for improved query handling.translator.go
incelery
package as a placeholder for future Celery integration logic.QueueFilters
andCeleryTask
structs fromkafka/model.go
.This description was created by for ece8518. It will automatically update as commits are pushed.