Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteSAMLProvider AWS #5015

Merged
merged 5 commits into from
Dec 19, 2024
Merged

DeleteSAMLProvider AWS #5015

merged 5 commits into from
Dec 19, 2024

Conversation

saakovv
Copy link
Contributor

@saakovv saakovv commented Sep 20, 2024

Summary of the Pull Request

Monitoring DeleteSAMLProvider events separately from UpdateSAMLProvider makes sense, since these actions have different contexts, risks, and consequences. Tracking both types of events allows you to more fully control changes in the configuration of SAML providers and respond faster to potential threats.

Changelog

Example Log Event

{ [-]
   awsCloud_account_ID: XXXX
   awsRegion: us-east-1
   cwlGroupname: aws-controltower/CloudTrailLogs
   eventCategory: Management
   eventID: 6b09429c
   eventName: DeleteSAMLProvider
   status:success
   eventSource: iam.amazonaws.com
   eventTime: 2024-09-12T07:53:45Z
   eventType: AwsApiCall
   eventVersion: 1.09
   managementEvent: true
   readOnly: false
   recipientAccountId: XXXX
   requestID: f082cd90
   requestParameters: { [-]
     sAMLProviderArn: arn:aws:iam::XXXX:saml-provider/AWSSSO_XXXX_DO_NOT_DELETE
   }
   responseElements: null
   sourceIPAddress: XXXX
   tlsDetails: { [-]
     cipherSuite: TLS_AES_128_GCM_SHA256
     clientProvidedHostHeader: iam.amazonaws.com
     tlsVersion: TLSv1.3
   }
   userAgent: Boto3/1.26.32 Python/3.10.14 Darwin/23.6.0 Botocore/1.29.32
   userIdentity: { [-]
     accessKeyId: XXXX
     accountId: XXXX
     arn: arn:aws:iam::XXXX:user/XXXX
     principalId: XXXX
     type: IAMUser
     userName: XXXX
   }
}

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

…er makes sense, since these actions have different contexts, risks, and consequences. Tracking both types of events allows you to more fully control changes in the configuration of SAML providers and respond faster to potential threats.
@github-actions github-actions bot added the Rules label Sep 20, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @saakovv 👋

It looks like this is your first pull request on the Sigma rules repository!

Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the Sigma community! 😃

@frack113 frack113 added the Author Input Required changes the require information from original author of the rules label Dec 14, 2024
@frack113 frack113 added 2nd Review Needed PR need a second approval and removed Author Input Required changes the require information from original author of the rules labels Dec 17, 2024
@nasbench nasbench merged commit a8d8dcf into SigmaHQ:master Dec 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2nd Review Needed PR need a second approval Rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants