Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 4.1 + iOS 11 (SFAuthenticationSession) #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Swift 4.1 + iOS 11 (SFAuthenticationSession) #41

wants to merge 5 commits into from

Conversation

Vinzius
Copy link

@Vinzius Vinzius commented Apr 3, 2018 •
edited
Loading

Hi,

Changes:

  • Project is now compatible with Swift 4.1.
  • Solved crashed with CFBundleURLSchemes if fb scheme isn't first.
  • Implemented SFAuthenticationSession if available.
  • Send more url parameter for Facebook to display the button "connect via facebook app" (else, only email/password is available).

I suggest:

  • More testing (other than Facebook)
  • Updating library version to 3.0

Edit: you can check the fb implementation of this API here

Cheers,
Vincent

pocketlim added a commit to pocketlim/Simplicity that referenced this pull request May 14, 2018
@pocketlim
Commit updates from SimplicityMobile#41
11d3acd 
Last updated Mon 14 May 2018
@zsigmondszilveszter
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vinzius @zsigmondszilveszter